-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for ogre 1.10 and 1.12 #8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
…da-forge-pinning 2021.03.22.11.12.50
I think this is good to go as soon as quay is back up. @wolfv do you want to have a look whether the pinnings look fine? |
@traversaro what's the idea to deal with downstream packages (libignition-gui4 and libignition-sensors4)? Do a similar treatment and build them with two variants? For context, this PR caused the PR here. |
I need to check ignition-rendering, but if the OGRE headers are not included as part of the public headers of ignition-rendering, probably there is no reason to have two builds of downstream libraries? |
I checked, and while ignition-rendering installs some headers with ogre neither ignition-gui nor ignition-sensors use them, so in theory the build should work fine with both ogre 1.10 and 1.12 . For downstream libraries such as ignition-sensors that seems to have runtime problems with ogre 1.12, what I was thinking to do is to have a run_constrained requirement ( https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run-constrained ) on ogre. |
However, this is just a theory, and we could have subtle problems related to this, so a safer alternative could be to just depend explicitly on ogre and build the two variants for all downstream libraries (this would have the advantage that we explicitly run the test suite against both ogre 1.12 and 1.10 and we easily detect problems). |
In any case, I think this PR is good to go. |
Agreed - shall we merge @wolfv? |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)