Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmp builds require openblas openmp builds #126

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 12, 2024

From the openblas faq:

OpenMP provides its own locking mechanisms, so when your code makes BLAS/LAPACK calls from inside OpenMP parallel regions it is imperative that you use an OpenBLAS that is built with USE_OPENMP=1, as otherwise deadlocks might occur.

This is likely the cause of #125 because the pthreads build of openblas is the default blas on linux, but any package that calls blas from within openmp must require openblas to also use openmp.

hopefully closes #125

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Thanks for the insight! I am currently travelling but I will check if this solves the problem as soon as I have access to a laptop.

@traversaro
Copy link
Contributor

Thanks, I just tested this in ami-iit/bipedal-locomotion-framework#886 and indeed it solves the problem!

@minrk minrk marked this pull request as ready for review September 13, 2024 07:32
@minrk minrk merged commit 6c5101b into conda-forge:main Sep 13, 2024
18 checks passed
@minrk minrk deleted the omp_require_openblas_omp branch September 13, 2024 07:33
@minrk
Copy link
Member Author

minrk commented Sep 13, 2024

Great, thank you!

@traversaro
Copy link
Contributor

@minrk Could it make sense to mark mumps-seq-5.7.3=*_3 as broken? I have CI (in ami-iit/bipedal-locomotion-framework#884) that still fail as somehow they are installing the _3 build:

2024-09-17T07:56:08.5855551Z     mumps-include-5.7.3        |       ha770c72_4          22 KB  conda-forge
2024-09-17T07:56:08.5856257Z     mumps-seq-5.7.3            |       h96124f5_3         2.3 MB  conda-forge

and still results in the hanging problem that is quite difficult to detect early on. If you agree, I can prepare the PR to the repo to ask for marking packages as broken.

@minrk
Copy link
Member Author

minrk commented Sep 17, 2024

I will backport the constraint to the repodata patches

@minrk
Copy link
Member Author

minrk commented Sep 17, 2024

@minrk
Copy link
Member Author

minrk commented Sep 17, 2024

btw, it's possible older builds may be getting picked due weighing down the openmp build via features. Related PR to try to address the inappropriate blas priority:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in mumps 5.7.3=*_3 build causing hang?
2 participants