Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 - more complete build including GL etc #16

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Fix #15 - more complete build including GL etc #16

merged 3 commits into from
Feb 21, 2020

Conversation

Tobias-Fischer
Copy link
Contributor

Checklist

Fix #15
This PR adds additional packages that allow building more libraries.

The following warnings appeared during the build process. As I am not sure how to deploy the docker build and test it in my conda environment, I ignored them for now.

WARNING (ogre): dso library package conda-forge::libglu-9.0.0-hf484d3e_1000 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (ogre): run-exports library package conda-forge::pugixml-1.10-he1b5a44_1 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
WARNING (ogre): dso library package conda-forge::mono-5.14.0.177-he1b5a44_1001 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

Let me know if you need further input.

Many thanks!

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@seanyen
Copy link
Contributor

seanyen commented Feb 20, 2020

LGTM. I think the warnings means that we don't have to add them into run requirements since it doesn't detect a dynamic-linkage from the output binaries. Do you mind remove them from the run and once the CI looks green I will just merge it.

@Tobias-Fischer
Copy link
Contributor Author

Thanks @seanyen - fixed the warnings and hopefully the windows build.

@Tobias-Fischer
Copy link
Contributor Author

Seems like the build was successful :)
@seanyen

@Tobias-Fischer
Copy link
Contributor Author

See https://gitlab.kitware.com/cmake/cmake/issues/17495 why the windows build fails without eac0e58

@seanyen seanyen merged commit f3405ff into conda-forge:master Feb 21, 2020
@seanyen
Copy link
Contributor

seanyen commented Feb 21, 2020

@Tobias-Fischer Thanks for the contribution!

@wolfv
Copy link
Member

wolfv commented Feb 21, 2020

yeah! awesome, thanks @Tobias-Fischer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderSystem_GL.so is not being exported
4 participants