Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch unittest.makeSuite to unblock Python 3.13 support #35

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 25, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Unblocks #34 by patching around conda/pycosat#100.

@bdice
Copy link
Contributor Author

bdice commented Nov 25, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 25, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

For recipe/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package pycosat using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12014858737. Examine the logs at this URL for more detail.

@bdice
Copy link
Contributor Author

bdice commented Nov 25, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits November 25, 2024 16:55
@bdice bdice mentioned this pull request Nov 25, 2024
@bdice bdice marked this pull request as ready for review November 25, 2024 18:03
@msarahan msarahan merged commit cb0a40f into conda-forge:main Nov 25, 2024
27 checks passed
@stonebig
Copy link

pushing an updated wheel on PyPi would be loved

@bdice
Copy link
Contributor Author

bdice commented Jan 4, 2025

@stonebig I filed a PR to update pycosat upstream here: conda/pycosat#101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants