Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuilt pytorch for MKL + numpy detection #252

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Rebuilt pytorch for MKL + numpy detection #252

merged 2 commits into from
Aug 25, 2024

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #251.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Aug 24, 2024
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Try to figure out why pytorch can't find numpy Aug 24, 2024
@hmaarrfk hmaarrfk changed the title Try to figure out why pytorch can't find numpy Try to figure out why pytorch can't find numpy for OSX Aug 24, 2024
@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_251 branch from 6efde86 to 0443223 Compare August 24, 2024 03:34
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Aug 24, 2024 •
edited
Loading

I think it has to do with cmake's new addition which kinda broke things for us.

The previous build had used cmake 3.29.5 on osx-64 and that patch was introduced in 3.30.0

@hmaarrfk hmaarrfk mentioned this pull request Aug 24, 2024
Closed
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk changed the title Try to figure out why pytorch can't find numpy for OSX Rebuilt pytorch for MKL + numpy detection Aug 24, 2024
hmaarrfk added a commit to conda-forge/admin-requests that referenced this pull request Aug 24, 2024
@hmaarrfk
Mark pytorch 2.4.0 osx + mkl build 0 as broken
5f86e74 
xref: conda-forge/numpy-feedstock#327
xref: conda-forge/pytorch-cpu-feedstock#252
This was referenced Aug 24, 2024
Merged
Merged
@hmaarrfk
Copy link
Contributor

Main:

2024-08-23T01:46:55.9080660Z   --   USE_MPS               : ON
2024-08-23T01:46:55.9080910Z   --   USE_MKL               : ON
2024-08-23T01:46:55.9081170Z   --   USE_MKLDNN            : ON
2024-08-23T01:46:55.9081440Z   --   USE_MKLDNN_ACL        : OFF
2024-08-23T01:46:55.9081730Z   --   USE_MKLDNN_CBLAS      : OFF
2024-08-23T01:46:55.9085040Z   --   USE_UCC               : OFF
2024-08-23T01:46:55.9085700Z   --   USE_ITT               : 0
2024-08-23T01:46:55.9087340Z   --   USE_NCCL              : OFF
2024-08-23T01:46:55.9087750Z   --   USE_NNPACK            : ON
2024-08-23T01:46:55.9088030Z   --   USE_NUMPY             : OFF

This PR:

2024-08-24T18:03:22.7211550Z   --   USE_MPS               : ON
2024-08-24T18:03:22.7211840Z   --   USE_MKL               :
2024-08-24T18:03:22.7212240Z   --   USE_MKLDNN            : ON
2024-08-24T18:03:22.7212560Z   --   USE_MKLDNN_ACL        : OFF
2024-08-24T18:03:22.7212990Z   --   USE_MKLDNN_CBLAS      : OFF
2024-08-24T18:03:22.7213620Z   --   USE_UCC               : OFF
2024-08-24T18:03:22.7213920Z   --   USE_ITT               : 0
2024-08-24T18:03:22.7214320Z   --   USE_NCCL              : OFF
2024-08-24T18:03:22.7214630Z   --   USE_NNPACK            : ON
2024-08-24T18:03:22.7215040Z   --   USE_NUMPY             : ON

@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_251 branch from 6e937b1 to fbda930 Compare August 24, 2024 21:44
@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Aug 24, 2024
Tobias-Fischer
Tobias-Fischer reviewed Aug 24, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_251 branch from fbda930 to 648e1a6 Compare August 24, 2024 22:09
@hmaarrfk hmaarrfk added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Aug 24, 2024
@hmaarrfk
Copy link
Contributor

ok here goes a full 20 hour build cycle. I guess we only need to wait 13 hours, that is GPU builds + OSX on main.

@hmaarrfk
Copy link
Contributor

I'm going to ask for foregiveness so i can work on some of the migration tomorrow.

@hmaarrfk hmaarrfk merged commit 6dd85b3 into conda-forge:main Aug 25, 2024
24 of 26 checks passed
h-vetinari
h-vetinari reviewed Aug 25, 2024
View reviewed changes
recipe/meta.yaml
# is wrong for conda-forge....
# https://github.com/numpy/numpy/issues/23775
# https://gitlab.kitware.com/cmake/cmake/-/blob/v3.30.2/Modules/FindPython/Support.cmake?ref_type=tags#L3906
- cmake !=3.30.0,!=3.30.1,!=3.30.2 # [osx and blas_impl == "mkl"]
Copy link
Member

@h-vetinari h-vetinari Aug 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed as of 3.30.2 AFAICT: Kitware/CMake@df551ee nevermind, misread the tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What aspect of that patch is wrong in conda-forge IYO (I'm not denying that detection didn't work before of course)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i couldn't figure it out either tbh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: #253

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets discuss and try to troubleshoot there.

h-vetinari pushed a commit to conda-forge/admin-requests that referenced this pull request Aug 26, 2024
@hmaarrfk
Mark pytorch 2.4.0 osx + mkl build 0 as broken (#1051)
6e593dc 
xref: conda-forge/numpy-feedstock#327
xref: conda-forge/pytorch-cpu-feedstock#252
This was referenced Aug 29, 2024
Closed
Closed
@hmaarrfk hmaarrfk mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@Tobias-Fischer Tobias-Fischer Tobias-Fischer left review comments

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@benjaminrwilson benjaminrwilson Awaiting requested review from benjaminrwilson benjaminrwilson is a code owner

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk hmaarrfk is a code owner

@sodre sodre Awaiting requested review from sodre sodre is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conda-forge-admin @hmaarrfk @Tobias-Fischer @h-vetinari