Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo failure of OSX Detection of numpy #253

Closed
wants to merge 9 commits into from
Closed

Demo failure of OSX Detection of numpy #253

wants to merge 9 commits into from

Conversation

hmaarrfk
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

conda-forge-webservices bot commented Aug 25, 2024 •
edited by conda-forge-admin
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk mentioned this pull request Aug 25, 2024
Merged
1 task
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Aug 25, 2024 •
edited
Loading

ps. build takes like 9 minutes to fail.

2024-08-25T12:31:43.7546270Z   CMake Debug Log at /Users/runner/miniforge3/conda-bld/libtorch_1724588719011/_build_env/share/cmake-3.30/Modules/FindPython/Support.cmake:3921 (find_path):
2024-08-25T12:31:43.7547830Z     find_path called with the following settings:
2024-08-25T12:31:43.7549320Z 
2024-08-25T12:31:43.7552720Z       VAR: _Python_NumPy_INCLUDE_DIR
2024-08-25T12:31:43.7555650Z       NAMES: "numpy/arrayobject.h"
2024-08-25T12:31:43.7557690Z              "numpy/numpyconfig.h"
2024-08-25T12:31:43.7558960Z       Documentation: Path to a file.
2024-08-25T12:31:43.7560580Z       Framework
2024-08-25T12:31:43.7562000Z         Only Search Frameworks: 0
2024-08-25T12:31:43.7563410Z         Search Frameworks Last: 0
2024-08-25T12:31:43.7565000Z         Search Frameworks First: 0
2024-08-25T12:31:43.7566810Z       AppBundle
2024-08-25T12:31:43.7568270Z         Only Search AppBundle: 0
2024-08-25T12:31:43.7569920Z         Search AppBundle Last: 0
2024-08-25T12:31:43.7571190Z         Search AppBundle First: 0
2024-08-25T12:31:43.7572680Z       NO_DEFAULT_PATH Enabled
2024-08-25T12:31:43.7573900Z 
2024-08-25T12:31:43.7575820Z     find_path considered the following locations:
2024-08-25T12:31:43.7576970Z 
2024-08-25T12:31:43.7579710Z       /Users/runner/miniforge3/conda-bld/libtorch_1724588719011/work/Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2 (Intel(R) SSE4.2) enabled only processors has been deprecated. Intel oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector Extensions (Intel(R) AVX) instructions.
2024-08-25T12:31:43.7581120Z 
2024-08-25T12:31:43.7582530Z     Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2
2024-08-25T12:31:43.7584220Z     (Intel(R) SSE4.2) enabled only processors has been deprecated.  Intel
2024-08-25T12:31:43.7585550Z     oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector
2024-08-25T12:31:43.7587370Z     Extensions (Intel(R) AVX) instructions.
2024-08-25T12:31:43.7588550Z 
2024-08-25T12:31:43.7589940Z 
2024-08-25T12:31:43.7592210Z     /Users/runner/miniforge3/conda-bld/libtorch_1724588719011/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/numpy/_core/include/numpy/arrayobject.h
2024-08-25T12:31:43.7593710Z 
2024-08-25T12:31:43.7594860Z 
2024-08-25T12:31:43.7597180Z       /Users/runner/miniforge3/conda-bld/libtorch_1724588719011/work/Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2 (Intel(R) SSE4.2) enabled only processors has been deprecated. Intel oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector Extensions (Intel(R) AVX) instructions.
2024-08-25T12:31:43.7598560Z 
2024-08-25T12:31:43.7599980Z     Intel MKL WARNING: Support of Intel(R) Streaming SIMD Extensions 4.2
2024-08-25T12:31:43.7601620Z     (Intel(R) SSE4.2) enabled only processors has been deprecated.  Intel
2024-08-25T12:31:43.7602810Z     oneAPI Math Kernel Library 2025.0 will require Intel(R) Advanced Vector
2024-08-25T12:31:43.7604290Z     Extensions (Intel(R) AVX) instructions.
2024-08-25T12:31:43.7605500Z 
2024-08-25T12:31:43.7607140Z 
2024-08-25T12:31:43.7608930Z     /Users/runner/miniforge3/conda-bld/libtorch_1724588719011/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/numpy/_core/include/numpy/numpyconfig.h
2024-08-25T12:31:43.7610440Z 
2024-08-25T12:31:43.7611750Z 
2024-08-25T12:31:43.7613180Z     The item was not found.

@hmaarrfk hmaarrfk mentioned this pull request Aug 25, 2024
Closed
@h-vetinari
Copy link
Member

Doesn't seem to trigger anymore with 3.30.3... 🤔

hmaarrfk
hmaarrfk commented Aug 31, 2024
View reviewed changes
recipe/build.sh
export USE_NUMPY=1

# # Force failure if numpy can't be found
# sed -i.bak 's/Python COMPONENTS Interpreter OPTIONAL_COMPONENTS/Python COMPONENTS Interpreter/g' cmake/Dependencies.cmake
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave this one. It helps fail eart

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that; I wasn't planning on merging the debug commits here anyway; I just wanted to ensure we don't need to hack CMake itself. I agree that we should keep the failsafe. Despite removing that now, I checked the logs an it does show

  --   USE_NUMPY             : ON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I could use your help in understanding why aarch64 isn’t detecting things…..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed that line from main since I felt it was too fragile.

But I think it is useful for debugging.

Aarch64 failures really puzzle me…..

@hmaarrfk
Copy link
Contributor Author

Unfortunately, the test still shows failure.

Also in #259

@hmaarrfk hmaarrfk closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer will be requested when the pull request is marked ready for review Tobias-Fischer is a code owner

@beckermr beckermr Awaiting requested review from beckermr beckermr will be requested when the pull request is marked ready for review beckermr is a code owner

@benjaminrwilson benjaminrwilson Awaiting requested review from benjaminrwilson benjaminrwilson will be requested when the pull request is marked ready for review benjaminrwilson is a code owner

@jeongseok-meta jeongseok-meta Awaiting requested review from jeongseok-meta jeongseok-meta will be requested when the pull request is marked ready for review jeongseok-meta is a code owner

@sodre sodre Awaiting requested review from sodre sodre will be requested when the pull request is marked ready for review sodre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @h-vetinari