Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for openssl3 #50

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update openssl3.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3109580846, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Hello @conda-forge/qt-main, there is anything I can do to help in getting this merged? My understanding is that probably this requires a manual build for aarch64, but perhaps I am wrong.

@Tobias-Fischer
Copy link
Contributor

I’m happy to do the aarch build if that is what is stopping this PR

@traversaro
Copy link
Contributor

I’m happy to do the aarch build if that is what is stopping this PR

Thanks a lot! Both Travis jobs are failing with The job exceeded the maximum log length, and has been terminated. so I guess that it is the case.

@andfoy
Copy link
Contributor

andfoy commented Oct 11, 2022

Just a heads up #41 (comment)

@Tobias-Fischer
Copy link
Contributor

I totally forgot that we discussed this before. Thanks for the reminder @andfoy.

@traversaro it seems like we’ll need to build some packages to also have OpenSSL 1.1 builds - do you know which ones are the culprit at the moment?

@traversaro
Copy link
Contributor

traversaro commented Oct 11, 2022

Just a heads up #41 (comment)

What is the blocking problem between qt5 and openssl 3 ? Ubuntu (https://packages.ubuntu.com/kinetic/libqt5network5), vcpkg and Debian (https://packages.debian.org/sid/libqt5network5) seem all to ship qt5 + openssl 3 . The debian related patch seem https://sources.debian.org/patches/qtbase-opensource-src/5.15.6%2Bdfsg-2/openssl3.diff/ .

@traversaro it seems like we’ll need to build some packages to also have OpenSSL 1.1 builds - do you know which ones are the culprit at the moment?

This is a good question. I arrived here as the tests in conda-forge/staged-recipes#20432 (comment) are failing as openssl 3 is installed with some dependencies that required qt-main, but I am not sure why openssl 3 is installed in the first place, as openssl 1 is use without problems during the build step.

@isuruf isuruf marked this pull request as draft October 22, 2022 20:28
@h-vetinari
Copy link
Member

h-vetinari commented Oct 23, 2022

@isuruf
What's missing here IYO (since you marked it as a draft)?

Aside from having to manually build for aarch/ppc, I think this should be fine?

@hmaarrfk hmaarrfk added the bot-rerun Instruct the bot to retry the PR label Oct 31, 2022
@hmaarrfk
Copy link
Contributor

building with emulation on x86 is not "fast" but it does work. I can do it on the next run. I just didn't see this.

@h-vetinari
Copy link
Member

building with emulation on x86 is not "fast" but it does work. I can do it on the next run. I just didn't see this.

Thanks a lot!

One thing that's going to be painful about this is that it doubles our build matrix on certain CFEP03-affected feedstocks (mainly qt & tensorflow), and we'll have to keep building both for a while yet.

I'm trying to see that we can get through the migration ASAP, but I'm not optimistic we won't hit another snag (e.g. packages that aren't ready; also, when this last came up in the core call, the anaconda folks mentioned they hadn't started OpenSSL 3 builds at all yet, so dropping 1.1.1 would have some cf-external impact - not that we need to care, but I think we probably do care anyway)

@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/3361290341

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-openssl3-0-1_hd3abc9 branch October 31, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants