Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring heavier deps from bioconda #26

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

luizirber
Copy link
Contributor

@luizirber luizirber commented Apr 1, 2022

This PR makes this package effectively the full sourmash, since all deps are listed here. bioconda will be a thin shell to allow creation of biocontainers.

Checklist

@luizirber luizirber requested review from bluegenes and ctb as code owners April 1, 2022 23:30
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@luizirber
Copy link
Contributor Author

@conda-forge-admin, please rerender

@ctb
Copy link
Contributor

ctb commented Apr 2, 2022

current build error on windows:

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>sourmash info   2>&1  | grep "4.3.0" 
'grep' is not recognized as an internal or external command,
operable program or batch file.

@luizirber
Copy link
Contributor Author

current build error on windows:

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>sourmash info   2>&1  | grep "4.3.0" 
'grep' is not recognized as an internal or external command,
operable program or batch file.

ah, that's why I removed that when I transferred from bioconda...

@luizirber luizirber merged commit 8a38a61 into conda-forge:main Apr 2, 2022
@luizirber luizirber deleted the lirber/bring_deps branch April 2, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants