-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document (and upgrade) windows support #1923
Comments
#2879 adds windows wheels |
(we continue having more downloads on windows than macos) |
this is probably a dumb question but - what is missing from the Windows install via sourmash-minimal? It seems like a fully functioning version of sourmash on my Mac laptop... |
Nothing. |
ok! is this a situation where we should consider removing sourmash from bioconda and rename it on conda-forge, for, say, sourmash v5? Or just leave it as is because it's not hurting anyone? 😆 documentation still needed tho... sigh. |
Previous times this
We have previous issues here (#502 (comment) #406 (comment)) from users of biocontainers, but I couldn't find a stats page like the one from conda-forge/bioconda to check how many downloads the images have. (does the "activity" in https://quay.io/repository/biocontainers/sourmash?tab=info mirrors downloads? Image also mirrored in https://gallery.ecr.aws/biocontainers/sourmash, but also no good info there) I wonder if the solution in #2503 (comment) actually works, will try to open a PR in bioconda and see how it goes.
As in how to set up a dev environment? For general use we usually assume conda or pip are already installed and working, instructions wouldn't change for windows |
thanks for all the updates!
just that we support Windows. I don't think we say it anywhere. |
Err, I may have found stats for biocontainers, but I don't believe the 21.7M downloads number 😅 |
…ort (#2928) Direct link to updated README: [link](https://github.com/sourmash-bio/sourmash/blob/update_readme/README.md) Adds repostatus badge as well as list of python versions supported. Switches to recommending conda-forge and sourmash-minimal, since that supports Windows ref #1923. Also adds direct mention of operating systems supported, including Windows (ref #1923). Fixes #2909 Fixes #2910
turns out we've supported windows for a little while, which I'd forgotten!
So people have been downloading
sourmash-minimal
on conda-forge (which supports Windows builds) and then installing extra deps themselves!Interesting side note, we're getting more downloads of sourmash-minimal on Windows than on Mac OS X.
@luizirber is almost finished with conda-forge/sourmash-minimal-feedstock#26, which is adding in the rest of the dependencies from sourmash into sourmash-minimal; this will make sourmash-minimal a full sourmash package, with full? Windows support.
So I think we should:
The text was updated successfully, but these errors were encountered: