Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dem_stitcher recipe #19470

Merged
merged 10 commits into from
Jul 22, 2022
Merged

Add dem_stitcher recipe #19470

merged 10 commits into from
Jul 22, 2022

Conversation

cmarshak
Copy link
Contributor

@cmarshak cmarshak commented Jun 28, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@cmarshak cmarshak changed the title get dem-stitcher into conda-forge Get dem_stitcher into conda-forge Jun 28, 2022
@jhkennedy
Copy link
Contributor

I am willing to be a maintainer

@jhkennedy
Copy link
Contributor

@conda-forge-admin, please lint

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dem_stitcher) and found some lint.

Here's what I've got...

For recipes/dem_stitcher:

  • Non noarch packages should have python requirement without any version constraints.

1 similar comment
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dem_stitcher) and found some lint.

Here's what I've got...

For recipes/dem_stitcher:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dem_stitcher) and found some lint.

Here's what I've got...

For recipes/dem_stitcher:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dem_stitcher) and found it was in an excellent condition.

@cmarshak cmarshak changed the title Get dem_stitcher into conda-forge Add dem_stitcher recipe Jun 29, 2022
@cmarshak
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general we should avoid a top pin if there's no known issues.

cmarshak and others added 2 commits July 21, 2022 16:32
@jhkennedy
Copy link
Contributor

jhkennedy commented Jul 22, 2022

@conda-forge/staged-recipes and or @conda-forge/help-python this should be ready to merge!

@ocefpaf ocefpaf merged commit 13e1563 into conda-forge:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants