Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for librobometry #20219

Merged
merged 8 commits into from
Sep 5, 2022
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 28, 2022

Add a recipe for the robometry C++ library. Given the discussion in #19764 (review), the recipe and conda package is called librobometry.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/librobometry) and found it was in an excellent condition.

@traversaro traversaro closed this Aug 28, 2022
@traversaro traversaro reopened this Aug 28, 2022
@traversaro
Copy link
Contributor Author

Due to the use of std::filesystem, on macOS the library needs to use 10.15 SDK, otherwise the following error appears:

[3/10] Building CXX object src/librobometry/CMakeFiles/robometry.dir/src/BufferManager.cpp.o
FAILED: src/librobometry/CMakeFiles/robometry.dir/src/BufferManager.cpp.o 
$BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -DBOOST_ALL_NO_LIB -DROBOMETRY_EXPORTS -I$SRC_DIR/src/librobometry/include -isystem $PREFIX/include/eigen3 -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/librobometry-1.1.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -O3 -DNDEBUG -isysroot /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.13 -fPIC -std=c++17 -MD -MT src/librobometry/CMakeFiles/robometry.dir/src/BufferManager.cpp.o -MF src/librobometry/CMakeFiles/robometry.dir/src/BufferManager.cpp.o.d -o src/librobometry/CMakeFiles/robometry.dir/src/BufferManager.cpp.o -c $SRC_DIR/src/librobometry/src/BufferManager.cpp
$SRC_DIR/src/librobometry/src/BufferManager.cpp:88:61: error: 'exists' is unavailable: introduced in macOS 10.15
$SRC_DIR/src/librobometry/src/BufferManager.cpp:88:68: error: 'path' is unavailable: introduced in macOS 10.15
    if (!m_bufferConfig.path.empty() && !yarp_telemetry_fs::exists(m_bufferConfig.path)) {
                                                                   ^
$BUILD_PREFIX/bin/../include/c++/v1/__filesystem/path.h:436:3: note: 'path' has been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
$SRC_DIR/src/librobometry/src/BufferManager.cpp:88:68: error: '~path' is unavailable: introduced in macOS 10.15
    if (!m_bufferConfig.path.empty() && !yarp_telemetry_fs::exists(m_bufferConfig.path)) {
                                                                   ^
$BUILD_PREFIX/bin/../include/c++/v1/__filesystem/path.h:458:3: note: '~path' has been explicitly marked unavailable here
  ~path() = default;
  ^
$SRC_DIR/src/librobometry/src/BufferManager.cpp:90:47: error: 'create_directory' is unavailable: introduced in macOS 10.15
        auto dir_created = yarp_telemetry_fs::create_directory(m_bufferConfig.path, ec);
                                              ^
$BUILD_PREFIX/bin/../include/c++/v1/__filesystem/operations.h:80:39: note: 'create_directory' has been explicitly marked unavailable here
inline _LIBCPP_INLINE_VISIBILITY bool create_directory(const path& __p, error_code& __ec) noexcept { return __create_directory(__p, &__ec); }
                                      ^
$SRC_DIR/src/librobometry/src/BufferManager.cpp:90:64: error: 'path' is unavailable: introduced in macOS 10.15
        auto dir_created = yarp_telemetry_fs::create_directory(m_bufferConfig.path, ec);
                                                               ^
$BUILD_PREFIX/bin/../include/c++/v1/__filesystem/path.h:436:3: note: 'path' has been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
$SRC_DIR/src/librobometry/src/BufferManager.cpp:90:64: error: '~path' is unavailable: introduced in macOS 10.15
        auto dir_created = yarp_telemetry_fs::create_directory(m_bufferConfig.path, ec);
                                                               ^
$BUILD_PREFIX/bin/../include/c++/v1/__filesystem/path.h:458:3: note: '~path' has been explicitly marked unavailable here
  ~path() = default;
  ^
6 errors generated.

@traversaro
Copy link
Contributor Author

@conda-forge/help-c-cpp The PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants