-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for libmatio-cpp #19764
Add recipe for libmatio-cpp #19764
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Windows build fails with:
probably a VS2017 problem. |
Switching to VS2019 solved the build problem. Given conda-forge/conda-forge.github.io#1810, I do not think it is particularly problematic to use VS2019. |
@conda-forge/help-c-cpp The recipe is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this libmatio
, see conda-forge/conda-forge.github.io#1073?.
I'm (re)starting to work through some of the xyz-cpp
-> libxyz
renames, but at least we could avoid adding new ones...
I realize that this package is a bit special because it is literally named matio-cpp
, but we have other packages that diverge from their upstream (or PyPI) names as well and for the consistency of the lib*
packages, I think this would be a good enough reason IMO. In this particular case, I'd say one could also consider libmatiocpp
, as that's the (lower-cased) name of the .so
produced on unix.
The problem is that libmatio already exists (https://github.com/conda-forge/libmatio-feedstock) and is the C library for which |
First off, I'm just one opinion among (potentially) many. Just wanted to add my $0.02.
Given that there really is a distinction between the C & C++ libs, I'd say that's a perfectly fine choice. It also happens to match what LLVM does for |
I renamed the package |
VS2019 is the latest pinning
Add recipe for matio-cpp.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).