-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for libgazebo-yarp-plugins package #21891
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gazebo-yarp-plugins:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
macOS is failing with:
So we need to bump the macOS version sdk to 10.14, so for now we just skip macOS. |
I think we can use conda_build_config.yaml here as well, can't we? |
Yes, I added it but it does not work on staged-recipes (at least the last time that I checked), so for now I just skipped macOS, and we can re-add it once the PR is merged. The CI checks now run fine, @conda-forge/help-c-cpp the recipe is ready for review, thanks! |
commands: | ||
- test -f ${PREFIX}/include/GazeboYarpPlugins/common.h # [not win] | ||
- test -f ${PREFIX}/lib/libgazebo_yarp_camera${SHLIB_EXT} # [unix] | ||
- if not exist %LIBRARY_INC%\\GazeboYarpPlugins\\common.h exit 1 # [win] | ||
- if not exist %LIBRARY_BIN%\\gazebo_yarp_camera.dll exit 1 # [win] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly recommend checking existence for all your shared libraries and some CMake files. You can use a loop in jinja to reduce the amount of boiler plate for the shared objects since they all start with the same $PREFIX/lib/libgazebo_yarp_
.
something like
{%for module in ['camera', 'foo'] %}
- test -f ${PREFIX}/lib/libgazebo_yarp_{{ module }}${SHLIB_EXT} # [unix]
- if not exist %LIBRARY_BIN%\\gazebo_yarp_{{ module }}.dll exit 1 # [win]
{%endfor%}
There's an example in the tk feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I was not aware of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address your comment in 192a30d . @carterbox
The windows checks now fail with:
However, those libraries are in a directory that is added in the PATH in the activation script of Gazebo, so I think we can just add them to |
There is an imath-related error:
However, it is not diretly related to the PR, it just steems that there is some wrong run_exports for imath, see conda-forge/imath-feedstock#6 . |
I did not realized this but CI is not passing, the PR is ready for review. @conda-forge/help-c-cpp @carterbox |
gazebo-yarp-plugins is a library of plugins to interface the Gazebo Classic simulator with the YARP middleware.
The recipe name contains the
lib
prefix as requested in #19764 (review) for C/C++ libraries.Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).