-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for libvulkan-loader package #21893
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vulkan-loader:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp The PR is ready for review. |
build: | ||
number: 0 | ||
ignore_run_exports_from: | ||
- libxcb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the version that is being packaged here was just using the headers of xcb, without linking the library, see https://github.com/KhronosGroup/Vulkan-Loader/blob/sdk-1.3.239.0/CMakeLists.txt#L180 . So keeping the run_exports
was creating warnings (or an error? I can't remember) during the build. I noticed that this just changed in the latest master in KhronosGroup/Vulkan-Loader#1136, so probably we will need anyhow to get rid of this in the next release.
summary: Khronos official Vulkan ICD desktop loader for Windows, Linux, and MacOS. | ||
|
||
extra: | ||
feedstock-name: vulkan-loader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this distinction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past I packaged several repositories called <something>
that just contained a C/C++ library, so I initially created a feedstock called lib<something>-feedstock
, and then more packages were added (such as <something>-python
, etc etc), and it turned out to be confusing for contributors to understand why the feedstock was called lib<something>-feedstock
while the original repo was called <something>
, and the feedstock name could not be (easily) changed. So, I started to create all the feedstosk by using the original repo name, a bit like debian source packages are named. Anyhow, I do not feel strongly about this, so I am happy to just name the feedstock as well libvulkan-loader
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for explaining.
So OSX seems to install a few things in
Otherwise, this looks great. cc @rossant |
Thanks for noticing this, I guess there should be some option to disable the installation of the library as a macOS framework, I will check this. |
I disable framework installation with a |
Looks good to me. Thanks! |
This adds the recipe for the
vulkan-loader
package.Repo: https://github.com/KhronosGroup/Vulkan-Loader .
Repology page: https://repology.org/project/vulkan-loader/versions .
The package name starts with
lib
given the discussion in #19764 (review) .Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).