-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for icub-firmware-shared packages #27675
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/example-v1/recipe.yaml: This is a v1 recipe and not yet lintable. We are working on it! For recipes/example/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
4a005dc
to
bfc9b70
Compare
@conda-forge/help-c-cpp @conda-forge/staged-recipes the PR is ready for review, thanks! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
icub-firmware-shared is a set of C++ libraries shared among the firmware and the high level software used to control the iCub and ergoCub humanoid robots.
It is not particularly useful by itself, but I want to package it as it is a dependency of the icub-main C++ library used in the iCub and ergoCub humanoid robots, see #27672 .
The proposed recipe adds two different packages:
libicub-firmware-shared
: This is the package that is meant to be used if the package is consumed as a C/C++ library, and linked to a downstream project. To do so, the package contains arun_exports
section. This package name contains thelib
prefix as requested in Add recipe for libmatio-cpp #19764 (review) for C/C++ libraries.icub-firmware-shared
: This is the package is an empty package that depends onlibicub-firmware-shared
and that is meant to simplify the transition from therobotology
channel in which theicub-firmware-shared
used to be called onlyicub-firmware-shared
, without thelib
prefix: https://anaconda.org/robotology/icub-firmware-shared .The feedstock is named
icub-firmware-shared
to match the repo name and support different package outputs names in the future.Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).