-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for icub-main packages #27692
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There are a bunch of overlinking errors:
GLU is probably a problem of missing run_exports or similar, while the openblas makes me wonder: why it is linking openblas instead of the generic blas? |
This should be solved in traversaro@f92eabf . Basically icub-main links the |
f39ab13
to
950b830
Compare
Interesting, on
|
This need to be investigated, and I plan to do so, but it is not essential for review of the PR. I will skip this on osx for now. |
Hi! This is the friendly automated conda-forge-linting service. I Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your |
0fc8f89
to
31458db
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp @conda-forge/staged-recipes the PR is ready for review, thanks! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
31458db
to
3b785a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, possibly only for my personal understanding.
55a0144
to
34924dc
Compare
34924dc
to
7588a51
Compare
Thanks @xhochy ! |
icub-main is a set of C++ libraries and executables that constitute the software used to control the iCub and ergoCub humanoid robots.
The proposed recipe adds two different packages:
libicub-main
: This is the package that is meant to be used if the package is consumed as a C/C++ library, and linked to a downstream project. To do so, the package contains arun_exports
section. This package name contains thelib
prefix as requested in Add recipe for libmatio-cpp #19764 (review) for C/C++ libraries.icub-main-python
: This is the package that contains Python bindings for the C++ libraries contained inlibicub-main
, wrapped via SWIG.icub-main
: This is the package is an empty meta-package that depends onlibicub-main
andicub-main-python
and is used to install all the outputs generated by theicub-main
repo.The feedstock is named
icub-main
to match the repo name and the main meta-packages output to install all the outputs.As the testing revealed some failures in python bindings on
osx
, for now theicub-main-python
andicub-main
outputs are disabled onosx
. The idea is to investigate and fix (and thus enable the outputs) in the feedstock.Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).