Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for opensubdiv #27800

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add recipe for opensubdiv #27800

merged 2 commits into from
Oct 10, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 6, 2024

opensubdiv is an Open-Source subdivision surface library written in C++ from Pixar.

The package name (libopensubdiv) contains the lib prefix as requested in #19764 (review) for C/C++ libraries. The feedstock is named opensubdiv to match the repo name and support different package outputs in the future, if that turns out to be necessary.

I am adding opensubdiv as it is a dependency for the usd library (https://github.com/PixarAnimationStudios/OpenUSD), that itself is a dependency of the mujoco library, see conda-forge/mujoco-feedstock#62 (comment) .

The package contains two patches, one to disable the installation of static libraries to be compliant with CFEP-03, and another to support compilation of shared libraries on Windows (see PixarAnimationStudios/OpenSubdiv#71 (comment)).

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opensubdiv/meta.yaml) and found some lint.

Here's what I've got...

For recipes/opensubdiv/meta.yaml:

For recipes/opensubdiv/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opensubdiv/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/opensubdiv/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opensubdiv/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-c-cpp The PR is ready for review, thanks!

Copy link
Contributor

github-actions bot commented Oct 7, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

recipes/opensubdiv/meta.yaml Outdated Show resolved Hide resolved
@xhochy
Copy link
Member

xhochy commented Oct 10, 2024

I can take care of the license later today.

Co-authored-by: Uwe L. Korn <[email protected]>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opensubdiv/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/opensubdiv/meta.yaml:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@traversaro
Copy link
Contributor Author

I can take care of the license later today.

Thanks! I wanted to open a conda-smithy issue but I forgot to do so, my bad.

@xhochy
Copy link
Member

xhochy commented Oct 10, 2024

@conda-forge-admin please relint

@xhochy xhochy merged commit 87cef4d into conda-forge:main Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants