-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for opensubdiv #27800
Add recipe for opensubdiv #27800
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/opensubdiv/meta.yaml:
For recipes/opensubdiv/meta.yaml:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipes/opensubdiv/meta.yaml:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
1cd152f
to
1827f20
Compare
@conda-forge/staged-recipes @conda-forge/help-c-cpp The PR is ready for review, thanks! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
I can take care of the license later today. |
Co-authored-by: Uwe L. Korn <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipes/opensubdiv/meta.yaml:
Documentation on acceptable licenses can be found here. |
Thanks! I wanted to open a conda-smithy issue but I forgot to do so, my bad. |
@conda-forge-admin please relint |
opensubdiv is an Open-Source subdivision surface library written in C++ from Pixar.
The package name (
libopensubdiv
) contains thelib
prefix as requested in #19764 (review) for C/C++ libraries. The feedstock is namedopensubdiv
to match the repo name and support different package outputs in the future, if that turns out to be necessary.I am adding opensubdiv as it is a dependency for the usd library (https://github.com/PixarAnimationStudios/OpenUSD), that itself is a dependency of the mujoco library, see conda-forge/mujoco-feedstock#62 (comment) .
The package contains two patches, one to disable the installation of static libraries to be compliant with CFEP-03, and another to support compilation of shared libraries on Windows (see PixarAnimationStudios/OpenSubdiv#71 (comment)).
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).