-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch directly from Microsoft rather than using installed version of MSVC #19
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Note that existing recipe does not package the license file, which is proprietary and most definitely not BSD as claimed. |
bfb0926
to
7d6318b
Compare
bump here @conda-forge/core |
bump @conda-forge/vc |
There's currently a problem building this due to |
Co-authored-by: Dave Hirschfeld <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
This looks good to me. Can we do VS2017 first though (or both VS2017 and VS2019)? |
Hi everyone, I am not sure if anyone is working on this, but I would be happy to give an hand to get this merged. If the blocking issue is still:
I can work on this. |
Yes, it's the only issue right now. Thanks for taking a look |
I started looking into this, I have a few question before actually opening a PR:
|
…da-forge-pinning 2020.12.21.13.42.08
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
…da-forge-pinning 2020.12.21.13.42.08
…ster/direct-fetch
…da-forge-pinning 2020.12.21.13.42.08
…da-forge-pinning 2020.12.21.13.42.08
Thanks @nowster |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #20
Closes #18