Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch directly from Microsoft rather than using installed version of MSVC #19

Merged
merged 28 commits into from
Dec 22, 2020

Conversation

nowster
Copy link
Contributor

@nowster nowster commented Jun 30, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #20
Closes #18

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2019_linux-64' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@nowster
Copy link
Contributor Author

nowster commented Jun 30, 2020

Note that existing recipe does not package the license file, which is proprietary and most definitely not BSD as claimed.

@nowster nowster force-pushed the nowster/direct-fetch branch from bfb0926 to 7d6318b Compare July 1, 2020 16:18
@beckermr
Copy link
Member

bump here @conda-forge/core

@beckermr
Copy link
Member

bump @conda-forge/vc

recipe/meta.yaml Outdated Show resolved Hide resolved
@nowster
Copy link
Contributor Author

nowster commented Aug 12, 2020

There's currently a problem building this due to run_exports pinning conflicts with previous installed versions of this package. I haven't been able to resolve them using the ignore_run_exports mechanisms.

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs2019_linux-64' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.
  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [37, 37, 40, 40].

@isuruf
Copy link
Member

isuruf commented Aug 29, 2020

This looks good to me. Can we do VS2017 first though (or both VS2017 and VS2019)?

@traversaro
Copy link
Contributor

traversaro commented Nov 15, 2020

Hi everyone, I am not sure if anyone is working on this, but I would be happy to give an hand to get this merged. If the blocking issue is still:

Can we do VS2017 first though (or both VS2017 and VS2019)?

I can work on this.

@isuruf
Copy link
Member

isuruf commented Nov 15, 2020

Yes, it's the only issue right now. Thanks for taking a look

@traversaro
Copy link
Contributor

I started looking into this, I have a few question before actually opening a PR:

  • For supporting both VS2017 and VS2019, does it make sense to use two separate branches as done in normal "feedstock" to generate different packages, or you had in mind another strategy?
  • There is any reason why 32-bit is still supported in this PR, or we can just drop support for it?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vs_linux-64' output doesn't have any tests.
  • It looks like the 'vc' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'vc' output doesn't have any tests.
  • It looks like the 'vs_linux-64' output doesn't have any tests.

@isuruf isuruf merged commit c46086b into conda-forge:master Dec 22, 2020
@isuruf
Copy link
Member

isuruf commented Dec 22, 2020

Thanks @nowster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First steps towards vs2019 optional feedstock
6 participants