hubspot Source #20
Closed
hubspot Source #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a common config and validator
Provide a source config
Implement a HubSpot API client
Implement a Snapshot iterator
Add HubSpot resource validation
* implement cdc iterator * limit items in cdc iterator * refactor multiline function arguments * add comment to the cdc createdAt condition * update comment
* remove resources that don't support cdc * update snapshot iterator - fix the incorrect behavior with the bufferSize and limit * simplify Snapshot's HasNext method * fix typo * move Snapshot's Stop method above the private methods * add sorting for timestamp-based resources * update sorting logic and switching to cdc mode * store initial snapshot timestamp in the position * reformat arguments * set the snapshot's initial timestamp to the cdc timestamp when switching * remove redundant ConvertToCDCPosition function * rename `do request` to `execute request`
* source documentation, first run * add empty resources.md * fmt README * fix typo * update configuration options documentation * `resource` -> `resources` * format source config table * add resource and source operations they support
* provide a new source config field `extraProperties` This field allows to specify a list of HubSpot resource properties to include in addition to the default. If any of the specified properties are not present on the requested HubSpot resource, they will be ignored. Only CRM resources support this. * add `extraProperties` format to the docs
oykmnk
changed the title
|
Included in #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to implement Source with Snapshot and CDC iterators.
Quick checks: