Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubspot Destination #21

Merged
merged 63 commits into from
Aug 10, 2023
Merged

hubspot Destination #21

merged 63 commits into from
Aug 10, 2023

Conversation

oykmnk
Copy link
Contributor

@oykmnk oykmnk commented Nov 4, 2022

Description

This PR seeks to implement Destination.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

oykmnk and others added 30 commits September 26, 2022 22:52
@oykmnk
implement common config
1a59888
@oykmnk
provide source config
6330617
@oykmnk
add one more test case for the source config
c1081dc
@oykmnk
Merge pull request #1 from conduitio-labs/common-config
a97a341 
Implement a common config and validator
@oykmnk
Merge pull request #2 from conduitio-labs/source-config
03678ba 
Provide a source config
@oykmnk
implement hubspot http client
069c5ce
@oykmnk
rename test functions
b89a466
@oykmnk
update comment
e7dddb3
@oykmnk
update dependencies
cc701dd
@oykmnk
enable check shadowing
799da82
@oykmnk
capture resp body if unexpected status code is occured
1db1230
@oykmnk
Merge pull request #3 from conduitio-labs/hubspot-client
216f1b2 
Implement a HubSpot API client
@oykmnk
add gte and lte validations
c7fc683
@oykmnk
implement snapshot iterator
3597b74
@oykmnk
provide the MaxRetries config field
feb099d
@oykmnk
add comment about hubspot's id
a21a294
@oykmnk
update poll's comment
d1d7ac1
@oykmnk
provide a consts for id and createdAt fields
3de26aa
@oykmnk
move iterator's errors to a separate file
b552201
@oykmnk
Merge pull request #4 from conduitio-labs/source-snapshot-iterator
e3bf884 
Implement a Snapshot iterator
@oykmnk
regenerate mocks
59b71ce
@oykmnk
add hubspot resource validation
139a897
@oykmnk
Merge pull request #5 from conduitio-labs/check-supported-resources
5ad458a 
Add HubSpot resource validation
@oykmnk
implement destination
6edae10
@oykmnk
pass a resource to the writer
ec40e88
@oykmnk
update the objectIdPlaceholder
b6dd4e1
@oykmnk
add teardown log
226cd5a
@oykmnk
update destination comments
38a118d
@oykmnk
Merge pull request #7 from conduitio-labs/destination-implementation
69de240 
Implement Destination
@oykmnk
Implement CDC iterator (#8)
25279b7 
* implement cdc iterator

* limit items in cdc iterator

* refactor multiline function arguments

* add comment to the cdc createdAt condition

* update comment
oykmnk and others added 6 commits October 31, 2022 17:57
@oykmnk
Merge branch 'develop' into destination
c4b81d2
@oykmnk
Add Destination documentation (#16)
562590c 
* add destination operations resources support

* add destination docs
@oykmnk
Implement acceptance tests (#17)
2283af0 
* use a different context for deletes in destination tests

* implement acceptance tests

* update `WriteToSource` method

* acceptance tests minor fixes

* wait for test data to be present, in integration tests
@oykmnk
Add extraProperties source config field (#19)
193471f 
* provide a new source config field `extraProperties`

This field allows to specify a list of HubSpot resource properties to include in addition to the default.

If any of the specified properties are not present on the requested HubSpot resource, they will be ignored.

Only CRM resources support this.

* add `extraProperties` format to the docs
@oykmnk
Merge branch 'develop' into destination
f4ed2ed
@oykmnk
fix test after merge
854c0a7
@oykmnk oykmnk requested review from hariso and maha-hajja November 4, 2022 10:26
@maha-hajja maha-hajja changed the title Implement Destination hubspot Destination Apr 12, 2023
@lovromazgon lovromazgon self-assigned this Aug 4, 2023
@lovromazgon
Update connector
57a2feb 
- update dependencies
- update go version
- fix golangci-lint config
- fix the way cleanup is done in destination integration tests
@lovromazgon
refactor tests
19b92cf
@lovromazgon lovromazgon changed the base branch from develop to main August 10, 2023 14:58
@lovromazgon lovromazgon merged commit 68d8815 into main Aug 10, 2023
@lovromazgon lovromazgon deleted the destination branch August 10, 2023 15:12
This was referenced Aug 10, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@hariso hariso Awaiting requested review from hariso

@maha-hajja maha-hajja Awaiting requested review from maha-hajja

Assignees

@lovromazgon lovromazgon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oykmnk @lovromazgon @BohdanMyronchuk