Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHLP-1138] refactor webhook #117

Conversation

ElvisHeredia
Copy link
Contributor

@ElvisHeredia ElvisHeredia commented Mar 23, 2023

Refactor to get webhook notification
CHLP-1138

@ElvisHeredia ElvisHeredia force-pushed the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch 6 times, most recently from 64d0651 to 9fdfb8b Compare March 30, 2023 23:51
fcarrero
fcarrero previously approved these changes Mar 31, 2023
@ElvisHeredia ElvisHeredia force-pushed the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch 2 times, most recently from 16d968b to 62b4d3b Compare April 26, 2023 20:31
@ElvisHeredia ElvisHeredia force-pushed the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch from 62b4d3b to 3bf8099 Compare May 23, 2023 19:13
@ElvisHeredia ElvisHeredia force-pushed the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch from 3bf8099 to 5f89ae3 Compare May 30, 2023 19:54
fcarrero
fcarrero previously approved these changes May 30, 2023
* Unify config var
* Separate form validation
* Add class to create the webhooks
* Remove unnecessary validations
* Remove duplicate code
@ElvisHeredia ElvisHeredia force-pushed the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch from 5f89ae3 to ac12853 Compare May 30, 2023 22:03
@ElvisHeredia ElvisHeredia merged commit 3c7a190 into master Jun 20, 2023
@ElvisHeredia ElvisHeredia deleted the feature/CHLP-1138-resolve-issues-to-publish-plugin-in-prestashop-store branch June 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants