Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent System.Net.Http version conflicts #68

Merged
merged 1 commit into from
May 25, 2023

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented May 24, 2023

Describe the purpose of your pull request

The library referenced a specific version of the System.Net.Http assembly (v4.3.4), which could cause version conflict issues in the case of net45 and net461 targets. This PR aims to solve this by changing the reference to the built-in version (v4.0.0), which is shipped as a part of the framework.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

…s (net45, net461) to avoid version conflicts
@adams85 adams85 requested a review from a team as a code owner May 24, 2023 14:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adams85 adams85 merged commit 0bda27f into master May 25, 2023
@adams85 adams85 deleted the fix/systemnethttp-version branch May 25, 2023 17:16
@adams85 adams85 mentioned this pull request May 31, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants