Revise dependencies #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adams85
force-pushed
the
revise-dependencies
branch
6 times, most recently
from
3631d26 to
5d54aa5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
laliconfigcat
approved these changes
Jun 5, 2023
endret
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
This PR is kind of a follow-up to #68
I revised the package references of other targets than .NET framework targets as well and it seems to me that we have some unnecessary or questionable references:
System.Net.Http(v4.3.4): this is an OOB (out-of-band) package which is for backporting newer improvements/fixes for older runtimes. However, MS don't advise using the separateSystem.Net.HttpNuGet package anymore because it may lead to complications (as we also experienced that ourselves). In the case of .NET 5+, referencing the package is pointless anyway because those runtimes include a newer version. In the case of older targets, I think we shouldn't require this package either but we'd better leave the decision to the end user to reference it in their application if they want to. So I propose removing this dependency completely.System.Text.RegularExpressions(v4.3.1): this is very similar toSystem.Net.Httpbut, based on the comment, it contains some security fix(es). So in targets older than .NET 5, it may make sense to require this dependency. However, I think it would be better to leave the decision to the end user in this case as well: let them reference it in their applications if they see fit but I'm not sure that we should make the decision for them by requiring this dependency via our library.System.Text.Json(v6.0.5): our library uses features which was introduced inSystem.Text.Jsonv6.0, so we need this one (except for .NET 6 which already includes it). However, I recommend referencing the oldest version that works for us instead of some arbitrary patch version. This version would be v6.0.0.Requirement checklist (only if applicable)