Revert "Avoid expensive findEntry call in segment metadata query (#10892)" #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che#10892)" This reverts commit 51a973a.
lokesh-lingarajan
approved these changes
Oct 1, 2021
xvrl
approved these changes
Oct 1, 2021
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: TessaIO <[email protected]> Co-authored-by: TessaIO <[email protected]>
pagrawal10
added a commit
that referenced
this pull request
Sep 23, 2024
…er (#49) (#226) * feat: add the number of merge buffers used for druid emitter (#49) Signed-off-by: TessaIO <[email protected]> Co-authored-by: TessaIO <[email protected]> * Update setMetric (#51) * Improve metrics emit (#52) * Fix checkstyle (#53) --------- Signed-off-by: TessaIO <[email protected]> Co-authored-by: TessaIO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 51a973a.
We were seeing spiky error rates in our druid queries with error msgs pertaining to segment metadata. So reverting the commit that we suspect introduced this issue.