[vtbackend] Refactor Sequencer into SequenceBuilder to increase code …
clang-tidy-review
There were 19 warnings
Details
src/vtbackend/Screen.h:111: warning: variable name 'r' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/Screen.h:111: warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
src/vtbackend/Screen.h:112: warning: variable name 'g' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/Screen.h:112: warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
src/vtbackend/Screen.h:113: warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/Screen.h:113: warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
src/vtbackend/SequenceBuilder.h:37: warning: constructor does not initialize these fields: _incrementInstructionCounter, _handler [cppcoreguidelines-pro-type-member-init]
src/vtbackend/SequenceBuilder.h:48: warning: statement should be inside braces [readability-braces-around-statements]
src/vtbackend/SequenceBuilder.h:76: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/SequenceBuilder.h:80: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/SequenceBuilder.h:100: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/SequenceBuilder.h:124: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/SequenceBuilder.h:147: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/SequenceBuilder.h:161: warning: all parameters should be named in a function [readability-named-parameter]
src/vtbackend/SequenceBuilder.h:164: warning: all parameters should be named in a function [readability-named-parameter]
src/vtbackend/Terminal.h:1154: warning: member 'terminal' of type 'Terminal &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
src/vtbackend/Terminal.h:1154: warning: member variable 'terminal' has public visibility [misc-non-private-member-variables-in-classes]
src/vtbackend/Terminal.h:1174: warning: member 'terminal' of type 'Terminal &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]
src/vtbackend/Terminal.h:1174: warning: member variable 'terminal' has public visibility [misc-non-private-member-variables-in-classes]
Annotations
Check warning on line 111 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: variable name 'r' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0f * 0xFFFF);
^
```
Check warning on line 111 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const r = static_cast<unsigned>(static_cast<float>(color.red) / 255.0F * 0xFFFF);
```
Check warning on line 112 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: variable name 'g' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0f * 0xFFFF);
^
```
Check warning on line 112 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const g = static_cast<unsigned>(static_cast<float>(color.green) / 255.0F * 0xFFFF);
```
Check warning on line 113 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: variable name 'b' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0f * 0xFFFF);
^
```
Check warning on line 113 in src/vtbackend/Screen.h
github-actions / clang-tidy-review
clang-tidy
warning: floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
```suggestion
auto const b = static_cast<unsigned>(static_cast<float>(color.blue) / 255.0F * 0xFFFF);
```
Check warning on line 37 in src/vtbackend/SequenceBuilder.h
github-actions / clang-tidy-review
clang-tidy
warning: constructor does not initialize these fields: _incrementInstructionCounter, _handler [cppcoreguidelines-pro-type-member-init]
src/vtbackend/SequenceBuilder.h:186:
```diff
- IncrementInstructionCounter _incrementInstructionCounter;
- Handler _handler;
+ IncrementInstructionCounter _incrementInstructionCounter{};
+ Handler _handler{};
```
Check warning on line 49 in src/vtbackend/SequenceBuilder.h
github-actions / clang-tidy-review
clang-tidy
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (vtParserLog) {
vtParserLog()("Parser error: {}", errorString);
}
```
Check warning on line 76 in src/vtbackend/SequenceBuilder.h
github-actions / clang-tidy-review
clang-tidy
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void collect(char ch) { _sequence.intermediateCharacters().push_back(ch); }
^
```
Check warning on line 80 in src/vtbackend/SequenceBuilder.h
github-actions / clang-tidy-review
clang-tidy
warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
void param(char ch) noexcept
^
```