Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x: drop 's390utils-base' #1831

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Jul 8, 2022

This package provides the genprotimg tool, but also depends on perl-* rpms, which we don't want
to be part of the image. As long as IBM Secure Execution is targeted for RHCOS we can drop its support
in FCOS for now.
RHCOS comes with a lot of perl-* rpms, so there s390utils-base wouldn't bring new unwanted dependencies.
For custom FCOS builds it's easier to:

$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/

coreos/fedora-coreos-tracker#1217

This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies. For custom FCOS builds it's easier to:
```
$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
```

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
@dustymabe
Copy link
Member

LGTM

@dustymabe dustymabe requested a review from jlebon July 8, 2022 13:08
@dustymabe
Copy link
Member

cc @jschintag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants