Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s390x: move genprotimg to s390utils-core.rpm to drop perl dependency #1217

Open
nikita-dubrovskii opened this issue Jun 3, 2022 · 8 comments
Open

s390x: move genprotimg to s390utils-core.rpm to drop perl dependency #1217

nikita-dubrovskii opened this issue Jun 3, 2022 · 8 comments

Comments

@nikita-dubrovskii
Copy link

To build SecureExecution qemu-secex.s390x.qcow2 image we use genprotimg tool, which comes with s390utils-base.rpm dependent on /usr/bin/perl.

genprotimg itself doesn't require perl and better to be part of s390utils-core.rpm (as zipl).
@jlebon jlebon mentioned this issue Jun 3, 2022
Merged
@jlebon
Copy link
Member

jlebon commented Jun 3, 2022

Thanks for filing this!

@sharkcz Any thoughts on this one? How feasible is it to move genprotimgto the core subpackage?

@sharkcz
Copy link

sharkcz commented Jun 3, 2022

genprotimg is a sysadmin tool, so it doesn't match the definition of the content going into s390utils-core. What is the actual problem? The need of having perl in a development or build environment?

@jlebon
Copy link
Member

jlebon commented Jun 3, 2022

Not just development. s390utils-base has a hard dep on /usr/bin/perl so it's pulling in Perl into s390x composes.

@bgilbert bgilbert changed the title s390x: move 'genprtoimg' to 's390utils-core.rpm' to drop 'perl' dependency s390x: move genprotimg to s390utils-core.rpm to drop perl dependency Jun 4, 2022
@jlebon jlebon mentioned this issue Jun 24, 2022
Merged
@jlebon
Copy link
Member

jlebon commented Jun 28, 2022

Any updates on this? If not in s390utils-core, having it be in a separate subpackage would also be completely fine.

LakshmiRavichandran1 added a commit to LakshmiRavichandran1/fedora-coreos-config that referenced this issue Jun 28, 2022
@LakshmiRavichandran1
denylist: ext.config.files.file-directory-permissions on s390x
49ad3bc 
some files added by s390utils base have write permission by default.
we need to denylist now and later the package be skipped once we have coreos/fedora-coreos-tracker#1217.
Merged
@jlebon jlebon mentioned this issue Jun 29, 2022
Closed
jlebon pushed a commit to LakshmiRavichandran1/fedora-coreos-config that referenced this issue Jun 29, 2022
@LakshmiRavichandran1 @jlebon
denylist: ext.config.files.file-directory-permissions on s390x
5926806 
some files added by s390utils base have write permission by default.
we need to denylist now and later the package be skipped once we have coreos/fedora-coreos-tracker#1217.
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this issue Jun 29, 2022
@LakshmiRavichandran1 @jlebon
denylist: ext.config.files.file-directory-permissions on s390x
3bf12af 
some files added by s390utils base have write permission by default.
we need to denylist now and later the package be skipped once we have coreos/fedora-coreos-tracker#1217.
nikita-dubrovskii added a commit to nikita-dubrovskii/fedora-coreos-config that referenced this issue Jul 8, 2022
@nikita-dubrovskii
s390x: drop 's390utils-base'
3e818df 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now. For custom
builds it's easier to put `genprotimg` directly into `overrides/rootfs/usr/bin/`.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies.

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
nikita-dubrovskii added a commit to nikita-dubrovskii/fedora-coreos-config that referenced this issue Jul 8, 2022
@nikita-dubrovskii
s390x: drop 's390utils-base'
b4e57c1 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now. For custom
builds it's easier to put `genprotimg` directly into `overrides/rootfs/usr/bin/`.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies.

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
nikita-dubrovskii added a commit to nikita-dubrovskii/fedora-coreos-config that referenced this issue Jul 8, 2022
@nikita-dubrovskii
s390x: drop 's390utils-base'
7d51290 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies.

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
@nikita-dubrovskii nikita-dubrovskii mentioned this issue Jul 8, 2022
Merged
nikita-dubrovskii added a commit to nikita-dubrovskii/os that referenced this issue Jul 8, 2022
@nikita-dubrovskii
s390x: add 'genprotimg' tool
fc65578 
This tool is required for IBM Secure Execution. Now it comes with
`s390utils-base` rpm, which depends on `perl-*` packages. Those are
already part of RHCOS, but not FCOS. Once the tool moves to `s390utils-core`
package, we can revert this patch.

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
@nikita-dubrovskii nikita-dubrovskii mentioned this issue Jul 8, 2022
Merged
nikita-dubrovskii added a commit to nikita-dubrovskii/fedora-coreos-config that referenced this issue Jul 8, 2022
@nikita-dubrovskii
s390x: drop 's390utils-base'
107eca8 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies. For custom FCOS builds it's easier to:
```
$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
```

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
@nikita-dubrovskii
Copy link
Author

nikita-dubrovskii commented Jul 8, 2022 •
edited
Loading

@sharkcz I guess, despite genprotimg is an sysadmin tool, as long as it's required for zipling and depends only on OpenSSL and glib2, it's better to put into s390utils-core.rpm . If that could be done, than also those files should be moved:

  • genprotimg/boot/stage3a.bin
  • genprotimg/boot/stage3b_reloc.bin

dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Jul 8, 2022
@nikita-dubrovskii @dustymabe
s390x: drop 's390utils-base'
f3cbb35 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies. For custom FCOS builds it's easier to:
```
$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
```

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Jul 18, 2022
@jlebon
manifests: exclude perl-interpreter
716ec9a 
We were excluding `perl`, but that's just a metapackage. The actual
interpreter is in `perl-interpreter`. Let's add that to the list to make
sure no package can pull it in.

Related: coreos/fedora-coreos-tracker#1217
@jlebon jlebon mentioned this issue Jul 18, 2022
Merged
jlebon added a commit to coreos/fedora-coreos-config that referenced this issue Jul 18, 2022
@jlebon
manifests: exclude perl-interpreter
a32c530 
We were excluding `perl`, but that's just a metapackage. The actual
interpreter is in `perl-interpreter`. Let's add that to the list to make
sure no package can pull it in.

Related: coreos/fedora-coreos-tracker#1217
@dustymabe
Copy link
Member

Where did we land on this?

@sharkcz
Copy link

sharkcz commented Jan 11, 2023

from the s390utils point of view - s390utils upstream plans to build a few cloud related tools from the current s390utils-base (eg. genprotimg) on non-s390x arches (x86 primarily), so it will require a new packaging solution. The plan was 8.8/9.2, but it didn't happen, thus I expect it to appear in the next cycle.

@dustymabe
Copy link
Member

Thanks @sharkcz for the update!

@jschintag jschintag mentioned this issue Mar 21, 2023
Closed
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@LakshmiRavichandran1 @HuijingHei
denylist: ext.config.files.file-directory-permissions on s390x
cf1cb06 
some files added by s390utils base have write permission by default.
we need to denylist now and later the package be skipped once we have coreos/fedora-coreos-tracker#1217.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@nikita-dubrovskii @HuijingHei
s390x: drop 's390utils-base'
8bcb7f4 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies. For custom FCOS builds it's easier to:
```
$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
```

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@jlebon @HuijingHei
manifests: exclude perl-interpreter
f630fbb 
We were excluding `perl`, but that's just a metapackage. The actual
interpreter is in `perl-interpreter`. Let's add that to the list to make
sure no package can pull it in.

Related: coreos/fedora-coreos-tracker#1217
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@LakshmiRavichandran1 @HuijingHei
denylist: ext.config.files.file-directory-permissions on s390x
437030f 
some files added by s390utils base have write permission by default.
we need to denylist now and later the package be skipped once we have coreos/fedora-coreos-tracker#1217.
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@nikita-dubrovskii @HuijingHei
s390x: drop 's390utils-base'
57d6a01 
This package provides the `genprotimg` tool, but also depends on `perl-*` rpms,
which we don't want to be part of the image. As long as IBM Secure Execution
is targeted for RHCOS we can drop its support in FCOS for now.
RHCOS comes with a lot of `perl-*` rpms, so there `s390utils-base` wouldn't
bring new unwanted dependencies. For custom FCOS builds it's easier to:
```
$ mkdir -p overrides/rootfs/usr/bin/
$ mkdir -p overrides/rootfs/usr/share/s390-tools/genprotimg
$ cp /path/to/genprotimg overrides/rootfs/usr/bin/
$ cp /path/to/stage3a.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
$ cp /path/to/stage3b_reloc.bin overrides/rootfs/usr/share/s390-tools/genprotimg/
```

coreos/fedora-coreos-tracker#1217

Signed-off-by: Nikita Dubrovskii <[email protected]>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@jlebon @HuijingHei
manifests: exclude perl-interpreter
147f951 
We were excluding `perl`, but that's just a metapackage. The actual
interpreter is in `perl-interpreter`. Let's add that to the list to make
sure no package can pull it in.

Related: coreos/fedora-coreos-tracker#1217
@dustymabe dustymabe mentioned this issue Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dustymabe @sharkcz @jlebon @nikita-dubrovskii