Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] window level tool for video #1088

Closed
sedghi opened this issue Feb 14, 2024 · 1 comment · Fixed by #1102
Closed

[Bug] window level tool for video #1088

sedghi opened this issue Feb 14, 2024 · 1 comment · Fixed by #1102
Assignees
@lscoder
Labels
Phase 2 Bug fix

Comments

@sedghi
Copy link
Member

sedghi commented Feb 14, 2024

Describe the Bug

https://www.cornerstonejs.org/live-examples/videocolor

It feels like the multiplier is too big and it shows very sudden changes in the brightness and contrast

Steps to Reproduce

d

The current behavior

d

The expected behavior

Most likely we should decrease that multiplier which should be easy

OS

d

Node version

d

Browser

d
@sedghi
Copy link
Member Author

sedghi commented Feb 15, 2024 •
edited
Loading

WindowLevelTool there is a DEFAULT_MULTIPLIER

lscoder added a commit to lscoder/cornerstone3D that referenced this issue Feb 16, 2024
@lscoder
fix: windowLevel dynamic range from video viewport (cornerstonejs#1088)
84a9c87
@lscoder lscoder linked a pull request Feb 16, 2024 that will close this issue
fix: windowLevel dynamic range from video viewport (#1088) #1102
Merged
@sedghi sedghi mentioned this issue Feb 16, 2024
Merged
sedghi pushed a commit that referenced this issue Feb 16, 2024
@lscoder
fix: windowLevel dynamic range from video viewport (#1088) (#1102)
1e3d435 
* fix: windowLevel dynamic range from video viewport (#1088)

* update api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lscoder lscoder

Labels
Phase 2 Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: windowLevel dynamic range from video viewport (#1088) lscoder/cornerstone3D
2 participants
@lscoder @sedghi