Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windowLevel dynamic range from video viewport (#1088) #1102

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

lscoder
Copy link
Collaborator

@lscoder lscoder commented Feb 16, 2024

fixes #1088

Context

WindowLevel tool was using a higher multiplier resulting in much faster changes to window width and window level making it harder to adjust.

Changes & Results

Changed the function responsible for getting the range from the viewport which was returning an array instead of a single number breaking the calculation of the ratio (NaN).

Testing

  • Open videoColor example
  • Click on the viewport to change the ww/wc

@lscoder lscoder requested a review from sedghi February 16, 2024 13:01
@lscoder lscoder self-assigned this Feb 16, 2024
@lscoder lscoder linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit 82bf68d
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65cf77481610de00087ba26a

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lscoder
Copy link
Collaborator Author

lscoder commented Feb 16, 2024

Much better thanks.

Update API please

reference the ticket to so that it gets closed https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

I'm manually linking my PRs to the bugs (see on right-side panel)

@sedghi sedghi merged commit 1e3d435 into cornerstonejs:main Feb 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] window level tool for video
2 participants