Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug EllipticalROITool #1011

Merged
merged 11 commits into from
Jan 19, 2024
Merged

fix: bug EllipticalROITool #1011

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8501192
Update getPixelData.ts
baokeyu123 Dec 25, 2023
58d1116
Merge branch 'cornerstonejs:main' into main
baokeyu123 Jan 10, 2024
ac0c5cf
Update ScaleOverlayTool.ts
baokeyu123 Jan 10, 2024
e02af5f
Merge branch 'cornerstonejs:main' into main
baokeyu123 Jan 16, 2024
efde8f5
Update createImage.ts
baokeyu123 Jan 16, 2024
ec5c6c7
Merge branch 'cornerstonejs:main' into main
baokeyu123 Jan 19, 2024
f2dd857
fix: update EllipticalROITool.ts bug about preventHandleOutsideImage
baokeyu123 Jan 19, 2024
8a0b8da
Rollback code createImage.ts
baokeyu123 Jan 19, 2024
d8db2da
callback createImage.ts
baokeyu123 Jan 19, 2024
ad1db0e
Update createImage.ts
baokeyu123 Jan 19, 2024
4fbb27e
Update createImage.ts
baokeyu123 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/tools/src/tools/annotation/EllipticalROITool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,8 @@ class EllipticalROITool extends AnnotationTool {
// Some area to do stats over.

if (this._isInsideVolume(worldPos1Index, worldPos2Index, dimensions)) {
this.isHandleOutsideImage = false;

const iMin = Math.min(worldPos1Index[0], worldPos2Index[0]);
const iMax = Math.max(worldPos1Index[0], worldPos2Index[0]);

Expand Down