Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contourSeg): polyline performance improvements #1061

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

lscoder
Copy link
Collaborator

@lscoder lscoder commented Feb 7, 2024

Context

Adding contour annotations may result in polylines with thousands of points making the viewer much slower to render the annotations and also process them (append, remove, create holes, interpolate, etc.).

Changes & Results

Implemented the Ramer–Douglas–Peucker algorithm that simplifies polylines based on an a given distance epsilon reducing the amount of points in a polyline.

Two polylines with 6k (source) and 7k (target) points were used on the test below to measure the time it would take to merge them before and after simplifying the polylines.

perf_polyline-simplification_merge

A good way to generate contours with +50k points is zooming all the way out before creating a freehand segmentation contour. Both polylines got simplified to new polylines with ~200 points or less each with no visual changes on the viewport. I know this is not a real example but that helped to measure the time it would take to process the contours.

line-simplification.mp4

Testing

Draw contours (spline, freehand, livewire) and make sure they are rendered and processed (append, remove, hole, interpolation, etc) correctly. A performance improvement is very noticeable when drawing multiple freehand ROIs.

@lscoder lscoder requested a review from sedghi February 7, 2024 16:37
@lscoder lscoder self-assigned this Feb 7, 2024
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit aefdbb0
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/65c4e2ca6a6efe0008adfd04
😎 Deploy Preview https://deploy-preview-1061--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@lscoder lscoder requested a review from sedghi February 7, 2024 20:20
@sedghi sedghi merged commit 1df02d4 into cornerstonejs:main Feb 8, 2024
9 checks passed
@sedghi sedghi changed the title feat(contourSeg): polyline performance improvement feat(contourSeg): polyline performance improvements Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants