-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Question tagging and Track progress #693
Conversation
@@ -114,6 +115,22 @@ class ComponentState(BaseComponentState, BaseState): | |||
velocity_reflection_state: VelocityReflection = VelocityReflection() | |||
reflection_complete: bool = False | |||
show_dop_cal4_values: bool = False | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My one suggestion would be that we move these two computed fields into the BaseComponentState
class so that we don't have to maintain this five times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought this would be a good thing to have in the base component state as well. I will add that
@johnarban, I have a few additional comments:
![]()
|
I have pushed the tracking to the |
…ed functions to handle component state
…ed functions to handle component state
3d47f2f
to
38c5091
Compare
This PR makes changes to help with accurately tracking progress and questions in the dashboard.
COMPONENT_STATE
to the question creation functions (some additional logic is included to capture questions from students who have gone through the story already).COMPONENT_STATE
tracks the progress itself via two new computed fieldsmax_step
andprogress
(afloat
on(0, 1]
)