-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle mc and fr questions as ref #774
Handle mc and fr questions as ref #774
Conversation
…ed functions to handle component state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me. But I haven't tried without @Carifio24's quick fix. Can you give this a shot after removing Jon's changes and see if you fix pre-filled FR or MC questions in two different app instances?
@nmearl , I ran it with the commits on cosmicds/cosmicds#361 removed. The free-response and mulitple choice questions were not shared between sessions for two different users run on a single solara server instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent -- looks good to me then!
Great, thanks @johnarban & @nmearl. Do we still need cosmicds/cosmicds#361 or do we want to undo those? |
And do we want to bring this over to the demo branch, or should we leave that alone since we know it works? |
This PR refactors the Multiple Choice and Free Response questions to be nested dictionaries that are updated using
Ref
s. This PR also makes sure the stage they belong to is a part of the question so they can be distinguished in the dashboard.The general sequence is
The
.copy()
seems necessary to prevent sharing modifications tofree_response
or 'mc_scoring` with other users. the mc and fr questions no longer have Pydantic models associated with them.