Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core API store support to return errors #14687

Closed
Tracked by #14683
aaronc opened this issue Jan 18, 2023 · 2 comments · Fixed by #14712
Closed
Tracked by #14683

Update core API store support to return errors #14687

aaronc opened this issue Jan 18, 2023 · 2 comments · Fixed by #14712
Assignees
Labels

Comments

@aaronc
Copy link
Member

aaronc commented Jan 18, 2023

Core API store support was added in #14326, but we changed the API to return errors in #14622 so now we have to update the implementation in runtime and also update the backport (#14326).

@aaronc aaronc mentioned this issue Jan 18, 2023
14 tasks
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 18, 2023
@tac0turtle tac0turtle self-assigned this Jan 20, 2023
@tac0turtle tac0turtle moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jan 20, 2023
@tac0turtle
Copy link
Member

to make this happen do you see us breaking the interface in the store package as well?

@aaronc
Copy link
Member Author

aaronc commented Jan 20, 2023

to make this happen do you see us breaking the interface in the store package as well?

No, just what core API provides (for now)

@github-project-automation github-project-automation bot moved this from 💪 In Progress to 👏 Done in Cosmos-SDK Jan 23, 2023
@tac0turtle tac0turtle removed the Q1:2023 label Apr 3, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants