Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add error to store interface #14622

Merged
merged 2 commits into from
Jan 14, 2023
Merged

refactor: add error to store interface #14622

merged 2 commits into from
Jan 14, 2023

Conversation

tac0turtle
Copy link
Member

Description

return error on store interface instead of panic


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner January 14, 2023 17:15
@github-prbot github-prbot requested review from a team, alexanderbez and julienrbrt and removed request for a team January 14, 2023 17:15
core/store/store.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle merged commit e6c22e3 into main Jan 14, 2023
@tac0turtle tac0turtle deleted the marko/error_store branch January 14, 2023 23:37
@aaronc
Copy link
Member

aaronc commented Jan 15, 2023

Shouldn't we do something similar with iterator methods?

@tac0turtle
Copy link
Member Author

Shouldn't we do something similar with iterator methods?

I added it, but then realized iterator has an Error() method that callers should check.

@aaronc
Copy link
Member

aaronc commented Jan 15, 2023

Shouldn't we do something similar with iterator methods?

I added it, but then realized iterator has an Error() method that callers should check.

Is that done properly in SDK code?

@tac0turtle
Copy link
Member Author

I don't think so, it seems we just assume

@aaronc
Copy link
Member

aaronc commented Jan 16, 2023

I don't think so, it seems we just assume

So maybe better to add it to the interface methods directly?

@tac0turtle
Copy link
Member Author

yea can make additions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants