-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implement core store API in runtime #14326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
commented
Dec 15, 2022
store.MemoryStoreService | ||
store.TransientStoreService | ||
intermodule.Client | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this from core because:
- we don't have
intermodule.Client
implemented yet - bundling all the store keys together means we need to register all these keys for every module and I don't think that's smart
So let's revisit the idea of a bundle service later to see if it makes sense
aaronc
added
the
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
label
Dec 15, 2022
aaronc
changed the title
feat!: implement core store API
feat!: implement core store API in runtime
Dec 15, 2022
[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed! |
alexanderbez
approved these changes
Dec 15, 2022
Imports needs some linting fixes, but otherwise LGTM. |
kocubinski
approved these changes
Dec 15, 2022
[Cosmos SDK] SonarCloud Quality Gate failed. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
(cherry picked from commit c275ec4)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the core store API introduced in #14227.
It also removes the bundle
Service
from core because I'm not sure we're ready to commit to that, see #14326 (comment).I am honestly not sure how to test this without migrating a module which would be breaking. If I don't break module APIs, this can be safely backported to 0.47 and then we can try it with collections and the circuit breaker module as a proof of concept.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change