Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement core store API in runtime #14326

Merged
merged 5 commits into from
Dec 15, 2022
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Dec 15, 2022

Description

This implements the core store API introduced in #14227.

It also removes the bundle Service from core because I'm not sure we're ready to commit to that, see #14326 (comment).

I am honestly not sure how to test this without migrating a module which would be breaking. If I don't break module APIs, this can be safely backported to 0.47 and then we can try it with collections and the circuit breaker module as a proof of concept.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

store.MemoryStoreService
store.TransientStoreService
intermodule.Client
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this from core because:

  1. we don't have intermodule.Client implemented yet
  2. bundling all the store keys together means we need to register all these keys for every module and I don't think that's smart

So let's revisit the idea of a bundle service later to see if it makes sense

@aaronc aaronc added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 15, 2022
@aaronc aaronc marked this pull request as ready for review December 15, 2022 19:58
@aaronc aaronc requested a review from a team as a code owner December 15, 2022 19:58
@aaronc aaronc changed the title feat!: implement core store API feat!: implement core store API in runtime Dec 15, 2022
@sonarqubecloud
Copy link

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kocubinski
Copy link
Member

Imports needs some linting fixes, but otherwise LGTM.

@aaronc aaronc enabled auto-merge (squash) December 15, 2022 20:57
@sonarqubecloud
Copy link

[Cosmos SDK] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@aaronc aaronc merged commit c275ec4 into main Dec 15, 2022
@aaronc aaronc deleted the aaronc/core-api-store-impl branch December 15, 2022 21:58
mergify bot pushed a commit that referenced this pull request Dec 15, 2022
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants