Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: require exported app wiring providers #13292

Merged
merged 53 commits into from
Oct 10, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Sep 14, 2022

Description

Ref #12556
Following up on #13115 this updates the SDK to cosmossdk.io/core v0.3.0 and cosmossdk.io/depinject v1.0.0-alpha.3 which require all depinject providers and their types to be exported and not in internal packages.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

aaronc and others added 30 commits August 2, 2022 11:39
…-export' into aaronc/depinject-codegen-require-export
…cosmos/cosmos-sdk into aaronc/depinject-codegen-require-export
@aaronc
Copy link
Member Author

aaronc commented Sep 27, 2022

Could I get another review of this?

@aaronc aaronc enabled auto-merge (squash) October 2, 2022 23:39
@julienrbrt
Copy link
Member

Seems like you should ./scripts/go-mod-tidy-all.sh, few other tests seems breaking btw.

@tac0turtle
Copy link
Member

hmm seems this still fails

@julienrbrt
Copy link
Member

hmm seems this still fails

cc @aaronc

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #13292 (f2da4b1) into main (c60c556) will increase coverage by 0.31%.
The diff coverage is 73.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13292      +/-   ##
==========================================
+ Coverage   53.77%   54.09%   +0.31%     
==========================================
  Files         653      650       -3     
  Lines       56828    55853     -975     
==========================================
- Hits        30561    30211     -350     
+ Misses      23823    23216     -607     
+ Partials     2444     2426      -18     
Impacted Files Coverage Δ
x/auth/vesting/module.go 10.25% <25.00%> (ø)
x/upgrade/module.go 28.35% <25.00%> (ø)
x/genutil/module.go 18.18% <33.33%> (ø)
x/authz/module/module.go 17.94% <40.00%> (ø)
x/params/module.go 22.41% <42.85%> (ø)
x/feegrant/module/module.go 15.38% <50.00%> (ø)
x/auth/module.go 54.05% <100.00%> (ø)
x/bank/module.go 61.16% <100.00%> (ø)
x/capability/module.go 66.19% <100.00%> (ø)
x/evidence/module.go 47.22% <100.00%> (ø)
... and 23 more

@julienrbrt
Copy link
Member

@aaronc there is still one test failing 🧐

@aaronc
Copy link
Member Author

aaronc commented Oct 5, 2022

I see. Thought I had everything. At a conference for a few days but will get to it soon

@aaronc aaronc merged commit f3a558c into main Oct 10, 2022
@aaronc aaronc deleted the aaronc/depinject-codegen-require-export4 branch October 10, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants