-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: require exported app wiring providers #13292
Conversation
…ject-codegen-require-export
…ject-codegen-require-export
…-export' into aaronc/depinject-codegen-require-export
…ject-codegen-require-export
…cosmos/cosmos-sdk into aaronc/depinject-codegen-require-export
…ject-codegen-require-export
…ject-codegen-require-export
…ject-codegen-require-export2
Could I get another review of this? |
Seems like you should |
hmm seems this still fails |
cc @aaronc |
…ject-codegen-require-export4
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13292 +/- ##
==========================================
+ Coverage 53.77% 54.09% +0.31%
==========================================
Files 653 650 -3
Lines 56828 55853 -975
==========================================
- Hits 30561 30211 -350
+ Misses 23823 23216 -607
+ Partials 2444 2426 -18
|
@aaronc there is still one test failing 🧐 |
I see. Thought I had everything. At a conference for a few days but will get to it soon |
…ject-codegen-require-export4
…ject-codegen-require-export4
Description
Ref #12556
Following up on #13115 this updates the SDK to
cosmossdk.io/core v0.3.0
andcosmossdk.io/depinject v1.0.0-alpha.3
which require all depinject providers and their types to be exported and not in internal packages.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change