Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update core module to depinject changes #13115

Merged
merged 35 commits into from
Sep 1, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Aug 31, 2022

Description

Ref #12556

This PR updates the appmodule code in core to reflect the depinject changes in #12797.

Note @julienrbrt @kocubinski that now because we're not using replace and go.work, that I need to update core, tag it and then update the main go module with these changes. This is the type of workflow that a multiple module repo requires with that sort of setup. The plus is that it allows and actually forces small PRs. The possible downside is that it could be a lot of PRs for small changes. replace and/or go.work could be used temporarily to get around that if it's a problem. Just something to be aware of.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

aaronc and others added 29 commits August 2, 2022 11:39
…-export' into aaronc/depinject-codegen-require-export
…cosmos/cosmos-sdk into aaronc/depinject-codegen-require-export

//
// Test Module Initialization Logic
//
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to move this here because depinject complained that it was in an internal package before.

@aaronc aaronc marked this pull request as ready for review August 31, 2022 21:48
@aaronc aaronc requested a review from a team as a code owner August 31, 2022 21:48
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #13115 (9e9303a) into main (3e3b225) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9e9303a differs from pull request most recent head 009f3cb. Consider uploading reports for the commit 009f3cb to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13115      +/-   ##
==========================================
+ Coverage   53.17%   53.20%   +0.02%     
==========================================
  Files         642      642              
  Lines       54959    54953       -6     
==========================================
+ Hits        29225    29236      +11     
+ Misses      23406    23391      -15     
+ Partials     2328     2326       -2     
Impacted Files Coverage Δ
core/appconfig/config.go 76.71% <100.00%> (ø)
x/mint/client/cli/query.go

@julienrbrt julienrbrt enabled auto-merge (squash) September 1, 2022 17:21
@julienrbrt julienrbrt merged commit bf8f015 into main Sep 1, 2022
@julienrbrt julienrbrt deleted the aaronc/depinject-codegen-require-export2 branch September 1, 2022 19:33
@julienrbrt julienrbrt mentioned this pull request May 12, 2023
19 tasks
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants