-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update core module to depinject changes #13115
Conversation
…ject-codegen-require-export
…ject-codegen-require-export
…-export' into aaronc/depinject-codegen-require-export
…ject-codegen-require-export
…cosmos/cosmos-sdk into aaronc/depinject-codegen-require-export
…ject-codegen-require-export
…ject-codegen-require-export
…ject-codegen-require-export2
|
||
// | ||
// Test Module Initialization Logic | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to move this here because depinject complained that it was in an internal
package before.
Codecov Report
@@ Coverage Diff @@
## main #13115 +/- ##
==========================================
+ Coverage 53.17% 53.20% +0.02%
==========================================
Files 642 642
Lines 54959 54953 -6
==========================================
+ Hits 29225 29236 +11
+ Misses 23406 23391 -15
+ Partials 2328 2326 -2
|
Description
Ref #12556
This PR updates the
appmodule
code incore
to reflect the depinject changes in #12797.Note @julienrbrt @kocubinski that now because we're not using
replace
andgo.work
, that I need to updatecore
, tag it and then update the main go module with these changes. This is the type of workflow that a multiple module repo requires with that sort of setup. The plus is that it allows and actually forces small PRs. The possible downside is that it could be a lot of PRs for small changes.replace
and/orgo.work
could be used temporarily to get around that if it's a problem. Just something to be aware of.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change