-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: implement core store API in runtime (backport #14326) #14330
Conversation
(cherry picked from commit c275ec4)
[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed! |
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
I'll let others comment on whether it's okay to backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to back ported?
ah I reviewed before seeing your comment. I don't think this needs to be back ported.
We'll backporting it makes it available for modules to use. I think that's valuable. If we don't put in 0.47.0, I would like to put in 0.47.1 |
lets do later, 0.47 is suppose to be feature freeze but we have been back porting everyhting |
So is first point release okay then? |
yea we can do additive changes post 0.47.0 |
We should put a slack reminder or smth then. |
@Mergifyio recreate |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: BD754 |
closing this for now, since Eden will be out soon |
This is an automatic backport of pull request #14326 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com