Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement core store API in runtime (backport #14326) #14330

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 15, 2022

This is an automatic backport of pull request #14326 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner December 15, 2022 21:59
@sonarqubecloud
Copy link

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aaronc
Copy link
Member

aaronc commented Dec 15, 2022

I'll let others comment on whether it's okay to backport.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to back ported?

ah I reviewed before seeing your comment. I don't think this needs to be back ported.

@aaronc
Copy link
Member

aaronc commented Dec 16, 2022

We'll backporting it makes it available for modules to use. I think that's valuable. If we don't put in 0.47.0, I would like to put in 0.47.1

@tac0turtle
Copy link
Member

lets do later, 0.47 is suppose to be feature freeze but we have been back porting everyhting

@aaronc
Copy link
Member

aaronc commented Dec 16, 2022

So is first point release okay then?

@tac0turtle
Copy link
Member

yea we can do additive changes post 0.47.0

@julienrbrt
Copy link
Member

We should put a slack reminder or smth then.

@julienrbrt julienrbrt closed this Dec 16, 2022
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-14326 branch December 16, 2022 15:47
@tac0turtle tac0turtle restored the mergify/bp/release/v0.47.x/pr-14326 branch March 20, 2023 14:46
@tac0turtle tac0turtle reopened this Mar 20, 2023
@tac0turtle
Copy link
Member

@Mergifyio recreate

@mergify
Copy link
Contributor Author

mergify bot commented Mar 20, 2023

recreate

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@tac0turtle
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor Author

mergify bot commented Mar 20, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/2)
Auto-merging runtime/module.go
CONFLICT (content): Merge conflict in runtime/module.go
error: could not apply 3951f8943... feat!: implement core store API in runtime (#14326)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 3951f8943... feat!: implement core store API in runtime (#14326)

err-code: BD754

@tac0turtle
Copy link
Member

closing this for now, since Eden will be out soon

@tac0turtle tac0turtle closed this Mar 20, 2023
@mergify mergify bot deleted the mergify/bp/release/v0.47.x/pr-14326 branch March 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants