Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had to do it manually (
git log --pretty=oneline core/v0.6.1..core/v0.7.0 ./core/**
for each tag and then cherry-picking the PR) because the changelog generation brings too much false positive.I think for getting a better changelog generation and remove the replace hell we have in our mono-repo, we should greatly limit the number of PRs touching multiples go mod and make them more contained.
It seems like we attempted doing this a while ago (see description), but I wonder why it hasn't sticked #13115. The downside doing that is that we need to tag way more.
I do not think we can get both of best world (pretty generated changelogs and big PRs). Personally I am fine with manual changelogs, but we really need to keep them up to date. Doing them manually from scratch isn't funny 😅
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change