Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Config Template #5166

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 9, 2019

Regression introduced by #5090

closes: #5165


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez merged commit 8d7cc5e into master Oct 9, 2019
@alexanderbez alexanderbez deleted the bez/5165-fix-app-config-tmpl branch October 9, 2019 19:57
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #5166 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5166   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         297      297           
  Lines       18255    18255           
=======================================
  Hits        10039    10039           
  Misses       7476     7476           
  Partials      740      740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server initialization fails while parsing config
2 participants