Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPCRouter #6325

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Add GRPCRouter #6325

merged 3 commits into from
Jun 3, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 2, 2020

ref: #5921


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@aaronc aaronc marked this pull request as ready for review June 2, 2020 20:08
@aaronc aaronc added the R4R label Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #6325 into master will increase coverage by 0.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #6325      +/-   ##
==========================================
+ Coverage   55.70%   55.71%   +0.01%     
==========================================
  Files         446      448       +2     
  Lines       26934    26978      +44     
==========================================
+ Hits        15004    15032      +28     
- Misses      10859    10869      +10     
- Partials     1071     1077       +6     

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few minor comments 👍

baseapp/grpcrouter.go Outdated Show resolved Hide resolved
}
}

// QueryServiceTestHelper provides a helper for making grpc query service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move test types and logic to separate file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpcrouter_helpers.go?

types/context.go Show resolved Hide resolved
@aaronc aaronc requested a review from alexanderbez June 2, 2020 20:32
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit e94b673 into master Jun 3, 2020
@alexanderbez alexanderbez deleted the aaronc/5921-grpc-router branch June 3, 2020 13:33
@aaronc aaronc mentioned this pull request Jun 10, 2020
11 tasks
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants