-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GRPCRouter #6325
Add GRPCRouter #6325
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6325 +/- ##
==========================================
+ Coverage 55.70% 55.71% +0.01%
==========================================
Files 446 448 +2
Lines 26934 26978 +44
==========================================
+ Hits 15004 15032 +28
- Misses 10859 10869 +10
- Partials 1071 1077 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few minor comments 👍
baseapp/grpcrouter.go
Outdated
} | ||
} | ||
|
||
// QueryServiceTestHelper provides a helper for making grpc query service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move test types and logic to separate file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grpcrouter_helpers.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
ref: #5921
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer