Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper support for Any in gRPC queries #6594

Merged
merged 4 commits into from
Jul 3, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jul 3, 2020

The initial PR's for gRPC (#6325, #6342) missed adding support for Any via AnyUnpacker/InterfaceRegistry. This PR adds:

  • support for unpacking Anys in requests via the GRPCQueryRouter.SetAnyUnpacker() method
  • support for unpacking Anys in CLI query calls via client.Context.InterfaceRegistry

Needed by #6593 and likely other PRs such as #6491.

/cc @blushi


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aaronc aaronc requested a review from blushi July 3, 2020 16:02
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6594 into master will decrease coverage by 0.03%.
The diff coverage is 51.11%.

@@            Coverage Diff             @@
##           master    #6594      +/-   ##
==========================================
- Coverage   57.21%   57.18%   -0.04%     
==========================================
  Files         481      481              
  Lines       28985    29015      +30     
==========================================
+ Hits        16585    16593       +8     
- Misses      11221    11241      +20     
- Partials     1179     1181       +2     

@aaronc aaronc marked this pull request as ready for review July 3, 2020 16:07
@aaronc aaronc added the R4R label Jul 3, 2020
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 3, 2020
@mergify mergify bot merged commit 849429e into master Jul 3, 2020
@mergify mergify bot deleted the aaronc/5921-grpc-any branch July 3, 2020 16:42
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Add proper gRPC Any support via AnyUnpacker

* Wire up grpc query router AnyUnpacker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:baseapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants