Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Module name in channel callback errors #1728

Closed
AdityaSripal opened this issue Jul 19, 2022 · 2 comments · Fixed by #2399
Closed

Include Module name in channel callback errors #1728

AdityaSripal opened this issue Jul 19, 2022 · 2 comments · Fixed by #2399
Assignees
@alizahidraja
Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@AdityaSripal
Copy link
Member

Better error messages indicating which module failed for OnChanOpenInit etc.

Taken from #40
@AdityaSripal AdityaSripal added the type: code hygiene Clean up code but without changing functionality or interfaces label Jul 19, 2022
@crodriguezvega
Copy link
Contributor 

sdkerrors.Wrapf(err, "channel open init callback failed for module: %s", module)
sdkerrors.Wrapf(err, "channel open try callback failed for module: %s", module)
sdkerrors.Wrapf(err, "channel open ack callback failed for module: %s", module)
sdkerrors.Wrapf(err, "channel open confirm callback failed for module: %s", module)
sdkerrors.Wrapf(err, "channel close init callback failed for module: %s", module)
sdkerrors.Wrapf(err, "channel close confirm callback failed for module: %s", module)

@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Aug 2, 2022
@alizahidraja alizahidraja mentioned this issue Sep 26, 2022
Closed
9 tasks
@alizahidraja
Copy link
Contributor

👋

@crodriguezvega crodriguezvega modified the milestone: v6.0.0 Sep 26, 2022
@alizahidraja alizahidraja mentioned this issue Sep 27, 2022
Merged
9 tasks
@mergify mergify bot closed this as completed in #2399 Sep 29, 2022
mergify bot pushed a commit that referenced this issue Sep 29, 2022
@alizahidraja
updated error calls with module names (#2399)
363970e 
## Description



Included Module names in channel callback errors

closes: #1728

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) (does not apply)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) (does not apply)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
mergify bot pushed a commit that referenced this issue Sep 29, 2022
@alizahidraja @mergify
updated error calls with module names (#2399)
d1ecf3f 
## Description

Included Module names in channel callback errors

closes: #1728

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) (does not apply)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) (does not apply)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 363970e)
damiannolan pushed a commit that referenced this issue Sep 29, 2022
@mergify @alizahidraja
chore: updated error calls with module names (#2399) (#2439)
0207728 
## Description

Included Module names in channel callback errors

closes: #1728

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) (does not apply)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) (does not apply)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 363970e)

Co-authored-by: Ali Zahid Raja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizahidraja alizahidraja

Labels
core good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
3 participants
@crodriguezvega @AdityaSripal @alizahidraja