Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors of channel handshake code #40

Closed
3 tasks
AdityaSripal opened this issue Nov 3, 2020 · 1 comment
Closed
3 tasks

Refactors of channel handshake code #40

AdityaSripal opened this issue Nov 3, 2020 · 1 comment
Labels
04-channel core type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@AdityaSripal
Copy link
Member

  • Pass channel objects around from msg to keeper methods directly rather than deconstructing into individual fields and reconstructing
  • Better error messages indicating which module failed for OnChanOpenInit etc.
  • Avoid calling GetChannel() twice in ConnOpenTry
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@colin-axner colin-axner added type: code hygiene Clean up code but without changing functionality or interfaces core labels Apr 21, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #40 from westaking/support_keyring
42f2c8f 
Update README.md for headless server
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@anilcse
Merge PR #40: Fix chain specific account prefixes
b8e8ec6
@AdityaSripal
Copy link
Member Author

I believe only the second is still relevant so will make that a new issue and close this one.

@AdityaSripal AdityaSripal mentioned this issue Jul 19, 2022
Closed
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Merge pull request cosmos#40 from lazyledger/tzdybal/addr_conversion
3f22ee1 
Bring back address conversion method. This is the easiest, non-obstructive method to enable running cosmos-sdk tests with optimint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04-channel core type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crodriguezvega @AdityaSripal @colin-axner