Fix error in Code Coverage workflow #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
changed the title
chatton
commented
Sep 13, 2022
| @@ -103,7 +103,7 @@ jobs: | |||
| if: env.GIT_DIFF | |||
| - name: test & coverage report creation | |||
| run: | | |||
| cat pkgs.txt.part.${{ matrix.part }} | xargs go test $(go list ./... | grep -v e2e) -race -mod=readonly -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock' | |||
There was a problem hiding this comment.
this was not reading the split input from the file, but was actually building a full list of all tests to run.
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
|
@crodriguezvega yes it looks like a duplicate issue, I've closed the original and updated the closes in the description! Thanks for pointing it out. |
colin-axner
approved these changes
Sep 15, 2022
chatton
deleted the
cian/issue#2281-investigate-long-times-of-code-coverage-task
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit 57e518c)
mergify bot
pushed a commit
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit 57e518c)
crodriguezvega
pushed a commit
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit 57e518c) Co-authored-by: Cian Hatton <[email protected]>
crodriguezvega
added a commit
that referenced
this pull request
Sep 20, 2022
(cherry picked from commit 57e518c) Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the e2e tests were introduced, the e2e tests were excluded from the unit tests in an incorrect fashion, which resulted in each task running all tests as opposed to splitting up the tests into 4 sections.
The workflow will be skipped on this PR as no go files are changed. See the this workflow which ran with the changes to see the run times.
closes: #2167
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes