Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in Code Coverage workflow #2282

Merged
merged 7 commits into from
Sep 16, 2022
Merged

Fix error in Code Coverage workflow #2282

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ede1a7e
chore: split build e2e into separate task
chatton Sep 13, 2022
d72c0fb
wip: temporarily remove git diff check
chatton Sep 13, 2022
f3a392c
wip: read tests from file
chatton Sep 13, 2022
4a7acbd
chore: move e2e build back into the original task
chatton Sep 13, 2022
54a2bae
chore: removed commented out if conditional
chatton Sep 13, 2022
ecf793e
Merge branch 'main' into cian/issue#2281-investigate-long-times-of-co…
chatton Sep 14, 2022
b3c326e
Merge branch 'main' into cian/issue#2281-investigate-long-times-of-co…
chatton Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Create a file with all the pkgs
run: go list ./... > pkgs.txt
run: go list ./... | grep -v e2e > pkgs.txt
- name: Split pkgs into 4 files
run: split -d -n l/4 pkgs.txt pkgs.txt.part.
# cache multiple
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
if: env.GIT_DIFF
- name: test & coverage report creation
run: |
cat pkgs.txt.part.${{ matrix.part }} | xargs go test $(go list ./... | grep -v e2e) -race -mod=readonly -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not reading the split input from the file, but was actually building a full list of all tests to run.

cat pkgs.txt.part.${{ matrix.part }} | xargs go test -mod=readonly -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock'
if: env.GIT_DIFF
- uses: actions/upload-artifact@v3
with:
Expand Down