You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there is an opportunity for more cleanup if we add an Ics03Connection variant to Ics04Error, because that will allow us to reuse errors from Ics03Error (and by extension Ics02Error using the Ics03Error::Ics02Client variant) and avoid redundant errors such as Ics04Error::ClientNotFound, MissingClientState, etc.
Proposal
Ics03Error can reuse Ics02Error, Ics04Error can recues Ics02Error and Ics03Error, and we remove redundant errors
Acceptance Criteria
Redundant errors are cleaned up
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate milestone (priority) applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Crate
IBC
Summary
We can clean up some modules' errors
Problem Definition
informalsystems/hermes#1283 (review)
Proposal
Ics03Error
can reuseIcs02Error
,Ics04Error
can recuesIcs02Error
andIcs03Error
, and we remove redundant errorsAcceptance Criteria
Redundant errors are cleaned up
For Admin Use
The text was updated successfully, but these errors were encountered: