Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove store_client_type interface #642

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

Farhad-Shabani
Copy link
Member

Closes: #592


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review April 20, 2023 17:11
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (9bb6327) 73.00% compared to head (115223f) 72.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   73.00%   72.91%   -0.09%     
==========================================
  Files         125      125              
  Lines       15663    15614      -49     
==========================================
- Hits        11434    11385      -49     
  Misses       4229     4229              
Impacted Files Coverage Δ
crates/ibc/src/core/context.rs 85.05% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 81.69% <ø> (-0.26%) ⬇️
crates/ibc/src/core/ics24_host/path.rs 92.21% <ø> (-0.25%) ⬇️
crates/ibc/src/mock/client_state.rs 90.26% <ø> (ø)
crates/ibc/src/mock/context.rs 73.89% <ø> (-0.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 9433091 into main Apr 24, 2023
@plafer plafer deleted the farhad/remove-store-client-type branch April 24, 2023 15:34
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICS02] Unclear role of ClientTypePath and respectively store_client_type method
2 participants