Add serialization for various structs and enums #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 72.97% 72.47% -0.51%
==========================================
Files 127 127
Lines 15696 15805 +109
==========================================
Hits 11454 11454
- Misses 4242 4351 +109
☔ View full report in Codecov by Sentry. |
Comment on lines
+47
to
+68
| #[cfg_attr( | ||
| feature = "parity-scale-codec", | ||
| derive( | ||
| parity_scale_codec::Encode, | ||
| parity_scale_codec::Decode, | ||
| scale_info::TypeInfo | ||
| ) | ||
| )] | ||
| #[cfg_attr( | ||
| feature = "borsh", | ||
| derive(borsh::BorshSerialize, borsh::BorshDeserialize) | ||
| )] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Display)] | ||
| #[display(fmt = "clients/{_0}/clientType")] | ||
| pub struct ClientTypePath(pub ClientId); | ||
|
|
||
| impl ClientTypePath { | ||
| pub fn new(client_id: &ClientId) -> ClientTypePath { | ||
| ClientTypePath(client_id.clone()) | ||
| } | ||
| } |
There was a problem hiding this comment.
This ClientTypePath should be dropped. Check here please.
Otherwise looks good to me 🙏
Farhad-Shabani
approved these changes
May 5, 2023
plafer
pushed a commit
that referenced
this pull request
May 5, 2023
* Add serialization for various structs and enums * Create 652-codec-borsh-serde.md --------- Signed-off-by: Davirain <[email protected]>
plafer
added a commit
that referenced
this pull request
May 5, 2023
* some docstrings updated * Remove dynamic_typing module * move some utils to tendermint client * Make `crate::utils` private * docs * Remove unused struct * move events under core * move timestamp under core * Move tx_msg under core * Make naming convention comment not module-level * Make core::handler private * Re-export all core::context * make tx_msg private and re-export Msg * core module docs * many docs improvements * Release v0.39.0 (#657) * unclog release * bump version * Correct issue 621 description --------- Co-authored-by: Farhad Shabani <[email protected]> * fix doc test * `Validation/ExecutionContext` method docs * more docs improvements * remove unused function * client docs improvements * move trust_threshold to tendermint * connection * finish ics-20 docs * finish docs for the tendermint light client * core docs * move `ModuleExtras` out of channel * Make all `TYPE_URL` private * Move `Acknowledgement ` * remove superfluous channel message modules * finish channel docs * Remove `ics05_port` module * ValidationError -> IdentifierError * remove error module * cleanup ics24_host path * move host validate module under identifier * move RouterError * move msgs under core * remove tx_msg * router module * remove arbitrary restrictions on `ModuleId` * router * finish ics23 * mock * fmt * Add serialization for various structs and enums (#653) * Add serialization for various structs and enums * Create 652-codec-borsh-serde.md --------- Signed-off-by: Davirain <[email protected]> * changelog * remove `ClientTypePath` --------- Signed-off-by: Davirain <[email protected]> Co-authored-by: Farhad Shabani <[email protected]> Co-authored-by: Davirain <[email protected]>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add serialization for various structs and enums * Create 652-codec-borsh-serde.md --------- Signed-off-by: Davirain <[email protected]>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* some docstrings updated * Remove dynamic_typing module * move some utils to tendermint client * Make `crate::utils` private * docs * Remove unused struct * move events under core * move timestamp under core * Move tx_msg under core * Make naming convention comment not module-level * Make core::handler private * Re-export all core::context * make tx_msg private and re-export Msg * core module docs * many docs improvements * Release v0.39.0 (#657) * unclog release * bump version * Correct issue 621 description --------- Co-authored-by: Farhad Shabani <[email protected]> * fix doc test * `Validation/ExecutionContext` method docs * more docs improvements * remove unused function * client docs improvements * move trust_threshold to tendermint * connection * finish ics-20 docs * finish docs for the tendermint light client * core docs * move `ModuleExtras` out of channel * Make all `TYPE_URL` private * Move `Acknowledgement ` * remove superfluous channel message modules * finish channel docs * Remove `ics05_port` module * ValidationError -> IdentifierError * remove error module * cleanup ics24_host path * move host validate module under identifier * move RouterError * move msgs under core * remove tx_msg * router module * remove arbitrary restrictions on `ModuleId` * router * finish ics23 * mock * fmt * Add serialization for various structs and enums (#653) * Add serialization for various structs and enums * Create 652-codec-borsh-serde.md --------- Signed-off-by: Davirain <[email protected]> * changelog * remove `ClientTypePath` --------- Signed-off-by: Davirain <[email protected]> Co-authored-by: Farhad Shabani <[email protected]> Co-authored-by: Davirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #652
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.